Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add support for dpi on menu icons on macos #584

Closed
grant0417 opened this issue Oct 10, 2022 · 1 comment · Fixed by #562 · May be fixed by grant0417/tao#1
Closed

[feat] Add support for dpi on menu icons on macos #584

grant0417 opened this issue Oct 10, 2022 · 1 comment · Fixed by #562 · May be fixed by grant0417/tao#1
Labels
platform: macOS type: bug

Comments

@grant0417
Copy link
Contributor

When using the CustomMenuItem API in Tao on macOS there is no way to represent high DPI icons. Typically you'd do that with @2x, but the icons is just loaded into memory and thus doesn't have that context.

https://docs.rs/tao/latest/tao/menu/struct.CustomMenuItem.html#method.set_icon

image
amrbashir added a commit that referenced this issue Oct 11, 2022
@amrbashir
fix(macos): scale menu item icon height to 18, closes #584
354ac90
@amrbashir
Copy link
Member

amrbashir commented Oct 11, 2022 •
edited
Loading

could you try macos-menu-icon-h-18 branch and see if it fixes the issue?

I don't have a mac to test 😅

@grant0417 grant0417 mentioned this issue Oct 15, 2022
Merged
13 tasks
@github-actions github-actions bot mentioned this issue Oct 15, 2022
Merged
@github-actions github-actions bot mentioned this issue Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform: macOS type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish New Versions tauri-apps/tao
Publish New Versions grant0417/tao
2 participants
@grant0417 @amrbashir