Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 9349e01

Browse files
arichardsongitbot
authored and
gitbot
committedMar 3, 2025
Remove l4re from the unsigned char operating system list
As noted in rust-lang#132975 (comment), the default for userland apps is to follow the architecture defaults, the -funsigned-char flag only applies to kernel builds.
1 parent e2317ea commit 9349e01

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎core/src/ffi/mod.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,8 @@ mod c_char_definition {
9797
// in clang/lib/Driver/ToolChains/Clang.cpp):
9898
// - PowerPC uses unsigned char for all targets except Darwin
9999
// - Arm/AArch64 uses unsigned char except for Darwin and Windows
100-
// - L4RE builds with -funsigned-char on all targets
100+
// Note: the L4RE kernel builds with -funsigned-char on all targets, but
101+
// we only have a target for userspace apps so it follows the architectures.
101102
if #[cfg(all(
102103
not(windows),
103104
not(target_vendor = "apple"),
@@ -113,7 +114,6 @@ mod c_char_definition {
113114
target_arch = "riscv32",
114115
target_arch = "s390x",
115116
target_arch = "xtensa",
116-
target_os = "l4re",
117117
)
118118
))] {
119119
pub type c_char = u8;

0 commit comments

Comments
 (0)
Failed to load comments.