Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5.2 - Any JS dependency changes? #36916

Open
chrisreddington opened this issue Aug 6, 2022 Discussed in #36881 · 5 comments
Open

Bootstrap 5.2 - Any JS dependency changes? #36916

chrisreddington opened this issue Aug 6, 2022 Discussed in #36881 · 5 comments

Comments

@chrisreddington
Copy link

Discussed in #36881

Originally posted by chrisreddington August 2, 2022
Hi Folks,

I wondered if anyone had any issues upgrading from Bootstrap 5.2 to 5.2? I'm aware that there were some changes on the sass side (so have imported the new maps partial), but seem to also be having issues with JavaScript.

I can't see anything called out in the Bootstrap 5.2 migration guide around JavaScript. I had a site with JavaScript that was working in 5.1, and now no longer working in 5.2. I am now seeing Uncaught TypeError: Class extends value undefined is not a constructor or null in my console, which hints to me that there's a dependency issue.

The theme itself for my site is hosted in my hugo creator repository, where you'll notice the example/demo site has the exact same issue (which could imply the issue on my end, and how i'm referencing the files - but haven't quite got that stage of identifying the issue yet!)

I'm referencing the individual files from node_modules, via the js/dist folder. The order that I'm referencing is -

"dom/data.js",
"dom/event-handler.js",
"dom/manipulator.js",
"dom/selector-engine.js",
"popper.js",
"base-component.js",
"carousel.js",
"collapse.js",
"dropdown.js"

Is there anything that I may need to consider going into 5.2 about the ordering of references for the individual components, or any dependency conflicts with other packages that may have been introduced?

Thanks!

@GeoSot
Copy link
Member

GeoSot commented Aug 6, 2022

You are probably referring to this change. #34509

We were thinking to deprecate the separated format, but as is still being used, I am trying to push a change #36854 which in combination with an esm build would be really handy as module.

For now if you want to move on 5.2. I suppose it would be better to use the dist/js/bootstrap.bundle.js

@GeoSot GeoSot added the js label Aug 6, 2022
@chrisreddington
Copy link
Author

Thanks @GeoSot - Ironically, I just stumbled upon #34509, then spotted that you responded to this issue, as it was tagged in the PR :)

It might be worth elevating this change into the Migration notes for 5.2. I spotted on the 5.2 Project Board that it notes js/dist is effectively now deprecated. But it took a lot of digging to find that info.

Thanks for the nudge though, much appreciated!

@chrisreddington
Copy link
Author

For anyone else encountering issues, can confirm that switching to using dist/js/boostrap.bundle.js worked again for me (thanks again @GeoSot).

Less than ideal, as my deploy now contain JS code for components that I am not using, but solves the immediate UI issues.

@mdo
Copy link
Member

mdo commented Dec 28, 2022

@GeoSot is this something to keep open and take action on, or should we close it out?

@GeoSot
Copy link
Member

GeoSot commented Dec 28, 2022

In case we want to use the independent J's built files, I think we need some small build changes ( I need to check it as I am not able to recall now )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants