Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection refused does not fail test #3353

Open
2 tasks done
koliyo opened this issue Oct 24, 2024 · 2 comments
Open
2 tasks done

Connection refused does not fail test #3353

koliyo opened this issue Oct 24, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@koliyo
Copy link

koliyo commented Oct 24, 2024

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

When my service is not running at all, and bruno get connection refused errors, this does not fail test results.

The tests and assertions are not executed, but requests should not be reported as passed, and everything should not be green

.bru file to reproduce the bug

No response

Screenshots/Live demo link

[18:40:07] ❯ bru run --env localhost e2e-test/
(node:99034) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
Running Folder 

e2e-test/01_post-topic ()
e2e-test/02_post-topic-viewpoint ()
e2e-test/03_post-comment-viewpoint ()
e2e-test/04_post-comment ()

Requests:    4 passed, 4 total
Tests:       0 passed, 0 total
Assertions:  0 passed, 0 total
Ran all requests - 0 ms
@koliyo koliyo added the bug Something isn't working label Oct 24, 2024
@koliyo
Copy link
Author

koliyo commented Oct 24, 2024

I'm using v1.33. While v1.34 is tagged in this repo, npm cli package is still v1.33

@helloanoop
Copy link
Contributor

Thanks for raising this, @koliyo!

I agree that requests shouldn’t be marked as passed, and the entire status shouldn't show green.
@Pragadesh-45, let’s set aside some time next week to review this and get it resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants