Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when adding a comment after an import in script setup #2102

Closed
drgarlic opened this issue Sep 12, 2020 · 1 comment · Fixed by #2107
Closed

Crash when adding a comment after an import in script setup #2102

drgarlic opened this issue Sep 12, 2020 · 1 comment · Fixed by #2107

Comments

@drgarlic
Copy link

drgarlic commented Sep 12, 2020 •
edited
Loading

Version

3.0.0-rc.10

Reproduction link

https://github.com/gawlk/vue-bug-comment-after-import

Steps to reproduce

  1. yarn create vite-app test-comment-crash
  2. yarn && yarn add mediasoup-client
  3. Go to App.vue and add the setup tag to <script>
  4. Lauch the app
  5. Add this import mediasoup from 'mediasoup-client' // remove this comment and it'll work BEFORE import HelloWorld from './components/HelloWorld.vue' otherwise it won't crash, it can't be after the latest import
  6. See that is crashes
  7. Remove the comment and see that it works

What is expected?

To work flawlessly

What is actually happening?

The app crashes because of a comment
@drgarlic drgarlic changed the title Crash when comment after a library import in script setup Crash when adding a comment after an import in script setup Sep 12, 2020
@posva
Copy link
Member

posva commented Sep 12, 2020

Please open an issue at https://github.com/vitejs/vite

@posva posva closed this as completed Sep 12, 2020
@drgarlic drgarlic mentioned this issue Sep 12, 2020
Closed
underfin added a commit to underfin/vue-next that referenced this issue Sep 13, 2020
@underfin
fix(compiler-sfc): should extract comment for import or type declarat…
25e4162 
…ions

fix vuejs#2102
@underfin underfin mentioned this issue Sep 13, 2020
Merged
yyx990803 pushed a commit that referenced this issue Sep 15, 2020
@underfin
fix(compiler-sfc): should extract comment for import or type declarat…
05df696 
…ions (#2107)

fix #2102
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-sfc): should extract comment for import or type declarat… underfin/vue-next
2 participants
@posva @drgarlic