Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent generation of local and remote CDDL files (missing definitions) #275

Closed
whimboo opened this issue Sep 8, 2022 · 2 comments · Fixed by #276
Closed

Inconsistent generation of local and remote CDDL files (missing definitions) #275

whimboo opened this issue Sep 8, 2022 · 2 comments · Fixed by #276
Assignees
Labels
cddl infra Infrastructure related issues

Comments

@whimboo
Copy link
Contributor

whimboo commented Sep 8, 2022

When generating the remote.cddl file I miss references to CapabilitiesRequest even through this type is marked for both local and remote.

CapabilitiesRequestParameters = {
  ?alwaysMatch: CapabilitiesRequest,
  ?firstMatch: [*CapabilitiesRequest]
}

Instead it's only listed in local.cddl, which isn't actually needed there given that the client won't have to parse that anyway.

@whimboo whimboo self-assigned this Sep 8, 2022
@whimboo
Copy link
Contributor Author

whimboo commented Sep 8, 2022

The problem here is that getCDDLNodes currently doesn't support multiple CDDL types within the same pre block. As such we weren't able yet to export valid data at all!

I've a version locally that works pretty fine now.

@muccimoz
Copy link

muccimoz commented Sep 9, 2022

2-points for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cddl infra Infrastructure related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants