Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private symbols from Vorbis shared libs #43

Open
yugr opened this issue May 13, 2018 · 0 comments
Open

Remove private symbols from Vorbis shared libs #43

yugr opened this issue May 13, 2018 · 0 comments

Comments

@yugr
Copy link

yugr commented May 13, 2018

I recently noticed that Vorbis shlibs export several symbols which are
not present in it's public header (for a total of 85 symbols, see
attach). Would it make sense to filter them via -fvisibility=hidden
and -Wl,--version-script? I attached a draft patch.

The issue was found using ShlibVisibilityChecker tool.

Private_symbols.txt
0001-Hide-private-symbols.patch.txt

As a side note, it seems that instructions on filing bugs at Vorbis site are outdated ("Bugs" at https://xiph.org/vorbis/ lead to Trac instead of Github).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant