Use real DOM for testing (2 of 2). #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resources are created in an iframe using real DOM elements as opposed to FakeElements.
el.href would return the canonical URL ("file://foo.bar") so we use el.getAttribute('href') instead ("//foo.bar").
Closes youtube#178
| // Test resources in an iframe. Use that as the document for all tests. | ||
| iframe = document.createElement('iframe'); | ||
| document.body.appendChild(iframe); | ||
| fakes.doc = iframe.contentWindow.document; |
There was a problem hiding this comment.
IE stumbles here. Working on another approach.
|
I've been pulled away from this and will need more time to resolve the IE problem. Closing this PR for now and will resubmit once a fix is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resources are created in an iframe using real DOM elements as opposed to FakeElements.
el.href would return the canonical URL ("file://foo.bar") so we use el.getAttribute('href') instead ("//foo.bar").
Closes #178