Page MenuHomePhabricator
Create Task
Maniphest T114883

Warning on repeated template parameters should use error class
Open, Needs TriagePublic
Actions

Description

When a template parameter has been repeated, e.g.

{{ttt | title=XYZ | url=http://example.org | title=ABC}}

a message is shown in source text preview

  • Warning: page is calling Template:ttt with more than one value for the "title" parameter. Only the last value provided will be used.

That message should be characterised by class="error".

  • Currently red color is inherited from .previewnote context.

Rationale:

  • Gadgets might detect errors somewhere in the preview and issue a warning next to [save] button, as remindErrorMessages already does.

BTW:

  • Is #invoke parameter list inspected, too? Same warning recommended.

Details

SubjectRepoBranchLines +/-
Add class warning to Warningmediawiki/coremaster+45 -3
Add class error to Warningmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

PerfektesChaos created this task.Oct 7 2015, 12:09 PM
PerfektesChaos raised the priority of this task from to Needs Triage.
PerfektesChaos updated the task description. (Show Details)
PerfektesChaos subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2015, 12:09 PM
Aklapper added projects: MediaWiki-Parser, good first task.Oct 7 2015, 1:00 PM

That's the 'duplicate-args-warning' string in MediaWiki's Parser code.
Adding good first task and Parser projects.

Apollyon96 subscribed.Dec 18 2015, 8:36 PM

I am interested in working on this bug.
I am new to MediaWiki. so it would be nice if someone could help me out.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 18 2015, 8:36 PM
Aklapper added a comment.Dec 18 2015, 11:10 PM

Hi @Apollyon96! Thanks for your interest! Please see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker for more info and don't hesitate to ask here if you have specific questions about this task. Thank you!

Apollyon96 added a comment.Dec 21 2015, 2:04 AM

Hey @Aklapper ! I have setup my local machine and am trying to recreate the error, but i am not so sure how to. Can you guide me on how to get the warning ? Also, I am trying to understand this code base along the way for further contribution.

Aklapper added a comment.Dec 21 2015, 10:41 AM

@Apollyon96: Have you imported/set up the ttt template (see Templates Help) and searched for 'duplicate-args-warning' string in MediaWiki core? If something is unclear with the comments in this task, please explain what you have tried. Thanks for working on this!

PerfektesChaos added a comment.Dec 21 2015, 6:17 PM
  • There is no need to import any template definition.
    • It would be sufficient to create an empty local page Template:ttt.
  • The error message issue would be triggered even if no such template exists.
  • The foo:bar template in task description was not intended to be the real w:en:Template:ttt with real meaning.
    • Actually, the example looks more like w:en:Template:cite web.
    • You might call it ttttt as well.
PerfektesChaos updated the task description. (Show Details)Dec 21 2015, 6:17 PM
PerfektesChaos set Security to None.
Praveenraj subscribed.Feb 4 2016, 3:07 PM

I like to work on this.

Praveenraj added a comment.Feb 4 2016, 4:39 PM

"duplicate-args-warning", I found this string in Preprocessor_DOM.php Preprocessor_hash.php, I have experienced this bug on my mediawiki instance, Please help me in solving this issue.

Aklapper added a comment.Feb 4 2016, 5:11 PM

@Praveenraj: Thanks for your interest! Please see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Feedback.2C_questions_and_support for questions and venues.

gerritbot subscribed.Mar 5 2016, 8:27 PM

Change 275208 had a related patch set uploaded (by Harjotsingh):
Add class error to Warning

https://gerrit.wikimedia.org/r/275208

gerritbot added a project: Patch-For-Review.Mar 5 2016, 8:27 PM
Jdlrobson subscribed.Jun 14 2016, 8:12 AM

This causes a font size increase and the two errors to appear on a single line like so:

Screen Shot 2016-06-14 at 4.08.26 PM.png (524×1 px, 83 KB)

We should avoid these changes in style by adding a rule .previewnote .error { font-size: inherit; } and adding newlines between the errors

Screen Shot 2016-06-14 at 4.09.13 PM.png (472×991 px, 71 KB)

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJun 14 2016, 8:12 AM
• Mattflaschen-WMF assigned this task to Harjotsingh.Oct 28 2016, 9:38 PM
Harjotsingh added a comment.Nov 5 2016, 6:01 PM
This comment was removed by Harjotsingh.
Harjotsingh added a comment.EditedNov 5 2016, 10:49 PM

@Jdlrobson @PerfektesChaos
I checked the bug on the latest code and the warning message is not showing at all even if a template parameter has been repeated.

Screenshot from 2016-11-06 04:13:20.png (718×1 px, 43 KB)

Jdlrobson added a comment.Nov 8 2016, 10:12 AM

@Harjotsingh you'll need to import the template ttt - notice how it is a red link in your preview.
https://en.wikipedia.org/wiki/Template:Ttt

You may want to experiment first on English Wikipedia to understand the bug by editing and copying the wikitext code in the original description:
https://en.wikipedia.org/wiki/User:<yourusername>/sandbox

Hope that helps and good luck!

gerritbot added a comment.Nov 9 2016, 4:18 PM

Change 320612 had a related patch set uploaded (by Harjotsingh):
Add class error to Warning

https://gerrit.wikimedia.org/r/320612

gerritbot added a comment.Nov 9 2016, 4:20 PM

Change 275208 abandoned by Harjotsingh:
Add class error to Warning

https://gerrit.wikimedia.org/r/275208

Harjotsingh added a comment.Apr 27 2017, 2:20 PM

As discussed over https://gerrit.wikimedia.org/r/320612, the class should be warning rather than error.

Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:36 PM
• Phabricator_maintenance moved this task from Doing to Backlog on the good first task board.Sep 24 2018, 9:52 AM
gerritbot added a comment.Feb 4 2020, 10:04 AM

Change 320612 abandoned by Jdlrobson:
Add class warning to Warning

Reason:
Let's discuss this more on the phabricator ticket.

https://gerrit.wikimedia.org/r/320612

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptFeb 4 2020, 10:04 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 4 2020, 10:10 AM
Aklapper removed Harjotsingh as the assignee of this task.Jun 19 2020, 4:16 PM
Aklapper added a subscriber: Harjotsingh.

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

Pppery removed a project: good first task.Aug 7 2024, 4:42 PM
Pppery subscribed.

This should be a good first task. But the carnage above shows it apparently isn't.

Pppery unsubscribed.Aug 7 2024, 4:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits