Page MenuHomePhabricator

Special:ActiveUsers' user interface is awkward (can't filter to arbitrary user groups)
Closed, ResolvedPublic

Description

https://en.wikipedia.org/wiki/Special:ActiveUsers has two checkboxes:

  • Hide bots
  • Hide administrators

What if I just want a list of active bureaucrats? Or active rollbackers? It'd be nice if you could filter to an arbitrary user group, I think. The checkboxes also feel kind of awkward.

Event Timeline

MZMcBride raised the priority of this task from to Needs Triage.
MZMcBride updated the task description. (Show Details)
MZMcBride subscribed.

Even with the dedicated checkbox, filtering to just a list of active admins doesn't seem possible. :-/

Should those checkboxes be replaced with a Special:Listusers like dropdown? Or should the checkboxes be left as is and and a new dropdown be added there without removing the checkboxes? Personally, I think the former option is better.

Change 288197 had a related patch set uploaded (by Sethakill):
Change checkboxes to dropdown.

https://gerrit.wikimedia.org/r/288197

I changed checkboxes to dropdown like Glaisher proposed. Now it looks like this:

Special-ActiveUsers.png (700×990 px, 68 KB)

Is that dropdown allow multiple selects (i.e. I want all admins ans stewards)? :)

@Trizek-WMF Unfortunately no. It's simple select field with groups.

Is it possible to have a multiple selects dropdown? :3

At this moment no. We need to design and implement this field. Is it necessary at all?

I'm considering possible cases: we had a way before to choose multiple
combinations with the checkboxes. I know some requests I can have to make
can be to select multiple roles at the same time. But I can do several
requests instead of one if that's too complicated to have a multiple-select
dropdown. :)

The very best would have been to have filters (all sysops or bureaucrats
but not sysops who are bureaucrats), but I think that requires more work.

I think it would be useful to have the ability to select multiple values from the input (e.g. Administrators (sysop) and stewards). However, currently, we don't have a nice widget for this, the only one would be a CapsuleMultiselectWidget (in OOJsUI), which, unfortunately, lacks a php only widget (so it works with JavaScript only, and therefore can't be used for forms, that are (and need to be) working without JavaScript. After this problem is resolved, we can create a HTMLForm widget for that and use it on Special:ActiveUsers. For the meantime, I think that the current state is a big improvement and can be used until we've a generalised multi-select widget (there are some open tasks for that, too: https://phabricator.wikimedia.org/search/query/erXUJ6Y5J5vT/#R).

matmarex added subscribers: matmarex, Zppix.

In the current version of the patch (patchset 9), the dropdown does allow multiselect.

pasted_file (595×1 px, 62 KB)

@matmarex Yeah, multiselect would allow rendering of "Active users" for either all users, or for one or more specified groups.

However the old functionality wasn't whitelisting two groups, it was excluding two groups. Specifically with the purpose to render a list of all active users that weren't bots or administrators.

Even if we ignore the use case of "Hiding both bots and administrators". The use case of "Hide bots" seems quite useful and would not be satisfied by a multiselect. Even if a user would try to work around it by selecting all other groups, that would be terrible UX, but also not work since a bot may be in multiple user groups. And the resulting permalink would break whenever a new group is created.

Hmm. I think the user case in the task description (show active users in this user group) is also sensible. I guess we should add options like "Not bots", "Not administrators" etc. to the dropdown?

Is it important to completely eliminate checkboxes?. We can add them in the group menu so the users can see what they have checked .They can again uncheck some options after which the result gets displayed immediately

In which file am i supposed to make changes in order to add my code?

Change 288197 merged by jenkins-bot:
SpecialActiveUsers: Change checkboxes to dropdown

https://gerrit.wikimedia.org/r/288197

Jdforrester-WMF subscribed.

Nice improvement here.

Hide bots doesn't work. Why I'm sort only users?

This comment was removed by Boshomi.

@Boshomi I think you meant to post that on some different task?…

Change 288197 merged by jenkins-bot:
SpecialActiveUsers: Change checkboxes to dropdown

https://gerrit.wikimedia.org/r/288197

Causes two regressions:

  1. "nobots" feature is now absent. As pointed out in T116354#2730127 this cannot be worked around.
  2. There is a flash of unstyled content in two aspects:
    • Labels have a blank space to the left of them that isn't there initially.
    • Checkboxes are visible at first but are replaced with a dropdown menu after 1-2 seconds or so when using www.mediawiki.org (Chrome latest, MacBook Pro, Fibre, unthrottled)
Screen Shot 2016-11-16 at 16.48.28.png (862×1 px, 116 KB)
Screen Shot 2016-11-16 at 16.48.27 2.png (698×1 px, 62 KB)
matmarex claimed this task.

Change 322265 had a related patch set uploaded (by Bartosz Dziewoński):
SpecialActiveUsers: Allow excluding groups too

https://gerrit.wikimedia.org/r/322265

"nobots" feature is now absent. As pointed out in T116354#2730127 this cannot be worked around.

Okay, I agree this was a mistake. The patch above brings this back.

Labels have a blank space to the left of them that isn't there initially.

This looks like a new Chrome bug regarding the display of <legend> elements, because I can't reproduce this in any other browsers, and it definitely was not happening when I was merging that patch. Filed as T151061.

Checkboxes are visible at first but are replaced with a dropdown menu after 1-2 seconds or so when using www.mediawiki.org (Chrome latest, MacBook Pro, Fibre, unthrottled)

Yes, this is known and was discussed on the patch. I think it's a very small issue, and resolving it would be a lot of work (we'd have to rewrite all the JS code that renders the dropdown into PHP, and render both the functional checkboxes and this non-functional fake in HTML output).

Change 322265 merged by jenkins-bot:
SpecialActiveUsers: Allow excluding groups too

https://gerrit.wikimedia.org/r/322265