I installed the Popups extension and found that HeaderTabs was keeping it from working because its js was trying to use cursheet's properties when cursheet was not defined.
Patch incoming.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Make sure we don't try to use an undefined var as an object | mediawiki/extensions/HeaderTabs | master | +12 -7 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 297131 had a related patch set uploaded (by MarkAHershberger):
Make sure we don't try to use an undefined var as an object
Comment Actions
Change 297131 abandoned by markahershberger:
Make sure we don't try to use an undefined var as an object
Comment Actions
This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!
For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)
Comment Actions
I don't know why I never approved (or even reviewed?) the 2016 patch, but this problem seems to have been fixed by a separate patch in 2019:
(Which is probably why the 2016 patch was abandoned.)