Table Date Sorting doesn't work correctly with blank fields
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WOSlinker
	Sep 1 2017, 5:59 PM

Description

With a table such as:

{| class="wikitable sortable"
! Name || Date || Number
|-
| A || 1967-01-01 || 1967
|-
| B || 1985-01-01 || 1985
|-
| C || 2001-01-01 || 2001
|-
| D || 1825-01-01 || 1825
|-
| E ||  || 
|}

When sorting on the date column, the blank values are placed in the middle of the table rather than at one of the ends.

Details

	Subject	Repo	Branch	Lines +/-
	TableSorter: Sort unrecognized dates as -Infinity	mediawiki/core	master	+3 -2

Customize query in gerrit

Event Timeline

WOSlinker created this task.Sep 1 2017, 5:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2017, 5:59 PM

WOSlinker updated the task description. (Show Details)Sep 1 2017, 5:59 PM

Reedy added a project: MediaWiki-General.Sep 1 2017, 6:31 PM

Cabayi subscribed.Sep 1 2017, 8:29 PM

A more tightly grouped set of dates in the table shows that blanks are interpreted as 1970-01-01.

{| class="wikitable sortable"
! Name || Date || Number
|-
| A || 1969-12-31 || 1969
|-
| B || 1970-01-02 || 1970
|-
| E ||  || 
|}

Cabayi renamed this task from Table Date Sorting doesn't not work corretly with blank fields to Table Date Sorting doesn't work correctly with blank fields.Sep 1 2017, 8:35 PM

Aklapper edited projects, added MediaWiki-jQuery-Tablesorter--archived; removed MediaWiki-General.Sep 2 2017, 8:34 AM

Thanks for reporting, I accidentally broke this a couple of weeks ago.

Change 375514 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/core@master] TableSorter: Sort unrecognized dates as -Infinity

https://gerrit.wikimedia.org/r/375514

gerritbot added a project: Patch-For-Review.Sep 2 2017, 9:32 AM

Change 375514 merged by jenkins-bot:
[mediawiki/core@master] TableSorter: Sort unrecognized dates as -Infinity

https://gerrit.wikimedia.org/r/375514

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Sep 2 2017, 10:00 PM

matmarex closed this task as Resolved.Sep 3 2017, 1:54 PM

matmarex assigned this task to TheDJ.

matmarex removed a project: Patch-For-Review.

Table Date Sorting doesn't work correctly with blank fieldsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Table Date Sorting doesn't work correctly with blank fields
Closed, ResolvedPublic
Actions