Page MenuHomePhabricator

CodeMirror loses changes on browser history moves
Closed, ResolvedPublic

Description

Steps to reproduce:

  • Load a random page.
  • Click on edit.
  • Disable CodeMirror.
  • Make a first change on the text.
  • Enable CodeMirror.
  • Make a second change on the text.
  • Click on browser history back.
  • Confirm the confirmation message.
  • Click on browser history forward.

Current result:
The text with the first changes is restored.

Expected result:
The text with the second changes should restored.

Event Timeline

Change 377197 had a related patch set uploaded (by Fomafix; owner: Fomafix):
[mediawiki/extensions/CodeMirror@master] ExecutecodeMirror.toTextArea() on beforeunload

https://gerrit.wikimedia.org/r/377197

Fomafix renamed this task from CodeMirror looses changes on browser history moves to CodeMirror loses changes on browser history moves.Sep 11 2017, 12:16 PM
Niharika triaged this task as Medium priority.Nov 7 2017, 11:34 PM

Change 377197 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Execute codeMirror.save() on beforeunload

https://gerrit.wikimedia.org/r/377197