Add 'fromsection' and 'tosection' to action=compare
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	Anomie
	Dec 30 2017, 5:54 PM

Description

The diffing in ApiQueryRevisionsBase that was deprecated in T164106 used the rvsection option, ApiComparePages should have an equivalent so things using that functionality can be migrated.

Details

	Subject	Repo	Branch	Lines +/-
	ApiComparePages: Update for MCR	mediawiki/core	master	+781 -268
	ApiComparePages: Add 'fromsection' and 'tosection' parameters	mediawiki/core	master	+72 -0

Customize query in gerrit

Related Objects

Mentioned In: T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase
Mentioned Here: T174032: Make relevant API modules aware of MCR
T185723: Compare full pages at section API diffs
T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase

Event Timeline

Anomie created this task.Dec 30 2017, 5:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 30 2017, 5:54 PM

Anomie mentioned this in T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase.Dec 30 2017, 5:54 PM

Anomie updated the task description. (Show Details)

Change 401090 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiComparePages: Add 'fromsection' and 'tosection' parameters

https://gerrit.wikimedia.org/r/401090

gerritbot added a project: Patch-For-Review.Dec 30 2017, 6:02 PM

Od1n awarded a token.Dec 30 2017, 6:47 PM

Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.Jan 2 2018, 3:28 PM

Change 401090 merged by jenkins-bot:
[mediawiki/core@master] ApiComparePages: Add 'fromsection' and 'tosection' parameters

https://gerrit.wikimedia.org/r/401090

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 4 2018, 8:00 AM

The new parameters should be deployed to WMF wikis with 1.31.0-wmf.16 or later. See https://www.mediawiki.org/wiki/MediaWiki_1.31/Roadmap for the schedule.

Change 448160 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] ApiComparePages: Update for MCR

https://gerrit.wikimedia.org/r/448160

After further consideration, this was a bad idea. We should have had fromsection and tosection work more like the section parameter to action=edit, expanding the fromtext/totext as if for a section edit and then doing a whole-page diff as requested in T185723: Compare full pages at section API diffs.

Since T174032: Make relevant API modules aware of MCR means we have to deprecate fromsection and tosection anyway in favor of per-slot versions, I'm going to have the new per-slot versions have the expansion behavior instead of the extraction behavior requested here.

Change 448160 merged by jenkins-bot:
[mediawiki/core@master] ApiComparePages: Update for MCR