Page MenuHomePhabricator

<select> on payments form is slightly taller than other fields in Firefox
Closed, ResolvedPublic

Description

See "State" input:

Screenshot 2018-02-15 14.44.23.png (380×882 px, 30 KB)

Works fine in Chrome and Safari.

https://stackoverflow.com/questions/9767612/issue-with-input-select-tag-height-in-form looks relevant

Event Timeline

Pcoombe created this task.

Just checked this, and it's still an issue but still very minor.

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)

Change 616122 had a related patch set uploaded (by Pcoombe; owner: Pcoombe):
[mediawiki/extensions/DonationInterface@master] Make select and inputs same height on Firefox

https://gerrit.wikimedia.org/r/616122

Change 616122 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Make select and inputs same height on Firefox

https://gerrit.wikimedia.org/r/616122

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

@Pcoombe - perhaps we can close this as declined for now? In the U.S., it looks like we're no longer using the <select> element as we've removed State as an input. I also don't see it in the other countries I spot checked.

@EWilfong_WMF We do still use it for Province in Canada, and State/territory in Australia

Pcoombe claimed this task.

That said, the patch got merged and does seem to have fixed it. I just forgot to close this task.