We have icons for all of these actions in the wikimediaui theme, and WikiEditor now supports OOUI icons.
| Before |  |
| After |  |
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T132023 VisualEditor support for editing inside CollaborationKit | |||
| Open | Feature | None | T138636 Allow using VisualEditor on Special:MassMessage | ||
| Open | None | T138642 VisualEditor should provide a clean integrated VE/WT editor widget that can be integrated into any context | |||
| Open | None | T130400 (Actually) Add wikitext support for citoid for automatic reference insertion | |||
| Open | None | T90864 Help VisualEditor users find the wikitext "Save" button | |||
| Open | None | T171974 Improve and consolidate our unified editing platform so that it's great on all devices | |||
| Open | None | T104479 Provide a modern wikitext editor | |||
| Resolved | Esanders | T91467 Use consistent icons for same/similar functions between editors | |||
| Resolved | Esanders | T191031 Use OOUI icons in WikiEditor | |||
| Resolved | Esanders | T143508 WikiEditor's Search and Replace icon is very similar to VisualEditor's "Switch to visual editing button", which is right next to it |
Event Timeline
Comment Actions
Change 422943 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikiEditor@master] Use OOUI icons for advanced format & size tools
Comment Actions
Change 423049 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikiEditor@master] Use OOUI icons for bold & italic
Comment Actions
Change 422943 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Use OOUI icons for advanced format & size tools
Comment Actions
When you change the search-and-replace to use the find icon, this would also fix T143508: WikiEditor's Search and Replace icon is very similar to VisualEditor's "Switch to visual editing button", which is right next to it.
Comment Actions
Change 424036 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikiEditor@master] Convert remaining tools to OOUI
Comment Actions
Note that the reference tool is using the 'book' icon, to minimise disruption, however this is not consistent with VE.
Comment Actions
This is a duplicate of T91467: Use consistent icons for same/similar functions between editors. I'm not sure which way is more convenient to merge them.
T148281: Redesign WikiEditor to look like VisualEditor might also be a duplicate, but it has unclear scope.
Comment Actions
Change 423049 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Use OOUI icons for bold & italic
Comment Actions
Saw some of these changes on Translatewiki, is there an expected time when this will be deployed on Wikipedias?
Comment Actions
Speaking of.. the look on monobook at translatewiki.net, looks substantially different to me from @Esanders his screenshots..
That seems as if it might be unintentional. Also I note that the new elements don't have textual content, only a title= attribute. As such this is a reduction in accessibility from before.
Comment Actions
It seems like Translatewiki uses old OOUI icons and Esanders uses new ones (see M229). Old ones have padding around them so they generally look smaller in such settings. Probably should be fixed on Translatewiki's end.
Comment Actions
Looks like we just forgot to override some margin on OOUI buttons that is only present in Apex theme (used by MonoBook).
Comment Actions
Change 425315 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/WikiEditor@master] Fix margin on OOUI icon buttons in Apex theme (MonoBook)
Comment Actions
You should raise that upstream in OOUI with @Volker_E. I don't know what the latest best practices are for accessible buttons.
Comment Actions
Also if you are referring to some icons being different in Apex that's because they are, but that will soon change with T169890.
Comment Actions
Change 425315 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Fix margin on OOUI icon buttons in Apex theme (MonoBook)
Comment Actions
Change 424036 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Convert remaining tools to OOUI
Comment Actions
@TheDJ It was you about three years ago filing T88979: Provide and enforce labels for all interactive widgets like ButtonWidgets (icon), PopupButtonWidget… :/
Comment Actions
The syntax highlighting icon (not shown in the images at the top of the task) and the switch-to-visual-editing icon look very similar. When we tell people to "click the pencil icon", they're going to get confused
See this screenshot, from https://en.wikipedia.org/w/index.php?title=Testing&redirect=no&action=submit
Comment Actions
@Whatamidoing-WMF I don't see any good solution on the icon side of things, both are the best possible outcome we've got following our design principles. “Click the black pencil in the corner” would be my first response.
Comment Actions
@Whatamidoing-WMF Previously discussed on T174145: Our standard highlight icon (used to enable/disable CodeMirror) cdxIconHighlight looks too much like our standard edit icon, cdxIconEdit… Maybe we should reopen that.
Comment Actions
TBH the highlighter icon in B&W doesn't seem so clear to me. I feel like I'd understand it more if I saw just the tip and the large ink mark such markers leave. A quick search engine lookup also seems to just show how conceptually a highlighter seems more tied to a larger and peculiar shape.