Maniphest T203063

PHP Fatal exception when viewing diffs for certain .map pages on Wikimedia Commons
Closed, DuplicatePublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	RP88
	Aug 29 2018, 7:30 AM

Description

On Commons if you click 'prev' on a revision of a .map dataset with a 'map.json' content model when the previous revision has a 'mediawiki' content model you get an Internal error like:

[W4ZLAQpAAD0AACzcXZsAAAAS] 2018-08-29 07:28:01: Fatal exception of type "MWException"

If possible this should succeed, or if this is too challenging a reasonable error message should be generated instead of an internal error.

Example link that produces the error:
https://commons.wikimedia.org/w/index.php?title=Data:Highway_192_in_Iowa_(3).map&diff=317407041&oldid=317406940

Interestingly if you click 'prev' on a revision of a .map dataset with a 'JSON' content model (instead of 'map.json') when the previous revision has a 'mediawiki' content model you get a successful diff. Example:
https://commons.wikimedia.org/w/index.php?title=Data:Highway_192_in_Iowa_(2).map&diff=317406375&oldid=317406229
So the internal error appears to be specific to the map.json content model.

Related Objects

Mentioned In: Blog Post: Production Excellence #5: November 2018
Mentioned Here: T203062: Unable to change content model to Map.Json

Event Timeline

RP88 created this task.Aug 29 2018, 7:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2018, 7:30 AM

RP88 updated the task description. (Show Details)Aug 29 2018, 7:39 AM

RP88 updated the task description. (Show Details)Aug 29 2018, 8:24 AM

RP88 updated the task description. (Show Details)Aug 29 2018, 8:26 AM

exception.file	       	/srv/mediawiki/php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCJsonDifferenceEngine.php:27
exception.message	       	JsonConfig\JCJsonDifferenceEngine does not support diffing between WikitextContent and JsonConfig\JCMapDataContent
exception.trace
#0 /srv/mediawiki/php-1.32.0-wmf.18/includes/diff/DifferenceEngineSlotDiffRenderer.php(58): JsonConfig\JCJsonDifferenceEngine->generateContentDiffBody(WikitextContent, JsonConfig\JCMapDataContent)
#1 /srv/mediawiki/php-1.32.0-wmf.18/includes/diff/DifferenceEngine.php(1024): DifferenceEngineSlotDiffRenderer->getDiff(WikitextContent, JsonConfig\JCMapDataContent)
#2 /srv/mediawiki/php-1.32.0-wmf.18/includes/diff/DifferenceEngine.php(942): DifferenceEngine->getDiffBody()
#3 /srv/mediawiki/php-1.32.0-wmf.18/includes/diff/DifferenceEngine.php(907): DifferenceEngine->getDiff(string, string, string)
#4 /srv/mediawiki/php-1.32.0-wmf.18/includes/diff/DifferenceEngine.php(701): DifferenceEngine->showDiff(string, string, string)
#5 /srv/mediawiki/php-1.32.0-wmf.18/includes/page/Article.php(737): DifferenceEngine->showDiffPage(boolean)
#6 /srv/mediawiki/php-1.32.0-wmf.18/includes/page/Article.php(464): Article->showDiffPage()
#7 /srv/mediawiki/php-1.32.0-wmf.18/includes/actions/ViewAction.php(68): Article->view()
#8 /srv/mediawiki/php-1.32.0-wmf.18/includes/MediaWiki.php(501): ViewAction->show()
#9 /srv/mediawiki/php-1.32.0-wmf.18/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#10 /srv/mediawiki/php-1.32.0-wmf.18/includes/MediaWiki.php(868): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.32.0-wmf.18/includes/MediaWiki.php(525): MediaWiki->main()
#12 /srv/mediawiki/php-1.32.0-wmf.18/index.php(42): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): include(string)
#14 {main}
exception_id	       	W4ZLAQpAAD0AACzcXZsAAAAS
exception_url	       	/w/index.php?title=Data:Highway_192_in_Iowa_(3).map&diff=317407041&oldid=317406940

Aklapper added a project: Wikimedia-production-error.Aug 29 2018, 8:51 AM

Rschen7754 subscribed.Aug 29 2018, 6:23 PM

This fatal error can be reproduced at the following url:

https://commons.wikimedia.org/w/index.php?title=Data:Highway_192_in_Iowa_(3).map&diff=317407041&oldid=317406940

Krinkle renamed this task from Internal error / Fatal exception when 'diff' performed between two revisions of .map dataset with different content models on Commons to PHP Fatal exception when viewing diffs for certain .map pages on Wikimedia Commons.Aug 29 2018, 9:08 PM

Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 16 2018, 6:46 PM

Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 1:21 AM

Krinkle mentioned this in Blog Post: Production Excellence #5: November 2018.Dec 12 2018, 4:40 AM

Tgr closed this task as a duplicate of T214217: Improve handling of diffs between different content types.Jan 19 2019, 12:14 AM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM

PHP Fatal exception when viewing diffs for certain .map pages on Wikimedia CommonsClosed, DuplicatePublicPRODUCTION ERRORActions

Description

Related Objects

Event Timeline

PHP Fatal exception when viewing diffs for certain .map pages on Wikimedia Commons
Closed, DuplicatePublicPRODUCTION ERROR
Actions