Add contains_all function to abuse filter
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• bzimport
	Jun 12 2009, 6:39 PM

Description

Author: Prodego

Description:
A function similar to the existing contains_any function, but instead only returning true if all substrings are present, would be useful both for cleanliness of code, and from an efficiency standpoint (less normalization in some cases).

Instead of

norm(haystack) contains "needle1" &
norm(haystack) contains "needle2" &
norm(haystack) contains "needle3"

contains_all(haystack,"needle1","needle2","needle3")

[contains_any is basically the same situation, except with the &'s replaces with |s]

Details

Reference: bz19176

	Subject	Repo	Branch	Lines +/-
	Add contains_all and ccnorm_contains_all functions	mediawiki/extensions/AbuseFilter	master	+82 -20

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:41 PM

• bzimport added a project: AbuseFilter.

• bzimport set Reference to bz19176.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Jun 12 2009, 6:39 PM

(Batch change)

These are low-priority miniprojects that I can mop up at some point when I'm doing general code work as opposed to working on a specific projects.

[Batch change]

Removing Dave McCabe from CC, who I somehow managed to add to the CC list of 12 bugs assigned to me.

• werdna unsubscribed.Dec 10 2014, 6:16 PM

Amire80 moved this task from Backlog to Filtering features on the AbuseFilter board.May 8 2016, 9:06 AM

This isn't hard to do, I'm working on it and I'll send a commit in a few days.

Change 391065 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Add contains_all function

https://gerrit.wikimedia.org/r/391065

gerritbot added a project: Patch-For-Review.Nov 13 2017, 7:17 PM

matej_suchanek added a project: User-notice.Feb 9 2018, 6:05 PM

matej_suchanek moved this task from To Triage to Announce in next Tech/News on the User-notice board.

Change 391065 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add contains_all and ccnorm_contains_all functions

https://gerrit.wikimedia.org/r/391065

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 9 2018, 7:00 PM

Hi, 2 requests: It looks like this new feature needs to be documented at
https://www.mediawiki.org/wiki/Extension:AbuseFilter/Rules_format

Please could you also help us to write the short explanation of this feature, for Tech/News? If I understand correctly, this might be clear and accurate?

The abuse filter extension has a new feature contains_all that will improve the efficiency and readability of some filters. [link to help page]

(I'm freezing next week's edition soon, so it will likely appear the week after that.) Thanks.

@Quiddity Right, I'll write the docs as soon as possible. I don't know how much details should be included in tech/news (I only wrote there once), but a relatively simple explaination could be:

The abuse filter extension has a new feature contains_all that you may use to check if one or more strings are all contained in another given string.

Please let me know if something else should be done.

Quiddity moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Feb 9 2018, 9:15 PM

matej_suchanek closed this task as Resolved.Feb 10 2018, 9:32 AM

matej_suchanek removed a project: Patch-For-Review.

matej_suchanek updated the task description. (Show Details)

matej_suchanek removed a subscriber: • wikibugs-l-list.

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Feb 14 2018, 7:36 PM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:55 PM