scrollbar breaks the modal
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Charlie_WMDE
	Oct 16 2019, 10:40 AM

Description

Steps to Reproduce:
open the bridge in beta, minimize the height of the window to force the modal to shrink so we get a scrollbar.

Actual Results:
the scrollbar is pertruding too far to the right and too high up and is scrolling away the sticky header.

Expected Results:
it should not go into the header but be below the header (see mocks for reference) and it should not scroll away the sticky header.

Details

	Subject	Repo	Branch	Lines +/-
	bridge: add scrollbar to body	mediawiki/extensions/Wikibase	master	+75 -103

Customize query in gerrit

Related Objects

Mentioned In: T235055: Create progressive disabled version of save button

Event Timeline

Charlie_WMDE created this task.Oct 16 2019, 10:40 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptOct 16 2019, 10:40 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 16 2019, 10:58 AM

"underneath" (on a layer under) vs. "below" (south of)?

South of, I assume – that is, only the content excluding the header should be scrollable.

That is my interpretation as well, but @Charlie_WMDE calls the shots.

Hey, sorry for the clumsy phrasing. You're both correct in your interpretation.

Charlie_WMDE moved this task from Incoming to Ready to estimate on the Wikidata-Bridge board.Oct 17 2019, 11:45 AM

WMDE-leszek updated the task description. (Show Details)Oct 22 2019, 9:26 AM

Charlie_WMDE updated the task description. (Show Details)Oct 22 2019, 9:26 AM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Oct 22 2019, 9:27 AM

WMDE-leszek set the point value for this task to 3.Oct 22 2019, 9:31 AM

Charlie_WMDE updated the task description. (Show Details)Oct 22 2019, 9:32 AM

Lucas_Werkmeister_WMDE mentioned this in T235055: Create progressive disabled version of save button.Oct 22 2019, 10:05 AM

Charlie_WMDE moved this task from Ready to estimate to Ready to pick up on the Wikidata-Bridge board.Oct 22 2019, 12:21 PM

• Pablo-WMDE edited projects, added Wikidata-Bridge-Sprint-8; removed Wikidata-Bridge.Oct 29 2019, 10:48 AM

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Oct 29 2019, 11:15 AM

• Matthias_Geisler_WMDE claimed this task.Oct 29 2019, 11:27 AM

• Matthias_Geisler_WMDE moved this task from To do to Doing on the Wikidata-Bridge-Sprint-8 board.

Change 546942 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/Wikibase@master] bridge: add scrollbar to body

https://gerrit.wikimedia.org/r/546942

gerritbot added a project: Patch-For-Review.Oct 29 2019, 2:13 PM

• Matthias_Geisler_WMDE moved this task from Doing to Peer Review on the Wikidata-Bridge-Sprint-8 board.Oct 29 2019, 2:14 PM

Change 546942 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add scrollbar to body

https://gerrit.wikimedia.org/r/546942

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikidata-Bridge-Sprint-8 board.Nov 5 2019, 1:59 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 5 2019, 2:10 PM

@Charlie_WMDE Please check and close :)

darthmon_wmde closed this task as Resolved.Nov 6 2019, 9:34 AM

darthmon_wmde moved this task from Verification to Done on the Wikidata-Bridge-Sprint-8 board.

	F30762421: Screen Shot 2019-10-16 at 12.57.53.png
	Oct 16 2019, 10:58 AM

	F30762417: Screen Shot 2019-10-16 at 12.57.42.png
	Oct 16 2019, 10:58 AM

scrollbar breaks the modalClosed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions

Description

Details

Related Objects

Event Timeline

scrollbar breaks the modal
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions