Page MenuHomePhabricator
Create Task
Maniphest T283641

Hard-deprecate DatabaseBlock 'byText' and 'by' with user ID
Closed, ResolvedPublic
Actions

Description

DatabaseBlock constructor accepts 'byText' property with blocker's name, and 'by' property with a blocker ID or, since I144603516b, a UserIdentity.

In cross-wiki blocking it's extremely easy to make a mistake and attribute the blocker to a local user with the same name or ID. Instead, these options for DatabaseBlock have to be hard-deprecated. The only remaining option should be providing a UserIdentity as a 'by' option.

Steps:

  1. Use codesearch to find all extensions that provide these options incorrectly. Make a list on this task. Fix extensions.
  2. Fix core.

Quick look over codesearch reveals that these options are mostly used in test codeso perhaps they can be removed without deprecation.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

• Pchelolo created this task.May 25 2021, 10:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2021, 10:04 PM
roman-stolar moved this task from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.May 28 2021, 12:59 PM
roman-stolar added a comment.May 28 2021, 2:02 PM

List of extension that should be updated/fixed:

  • EntitySchema -> (RestoreSubmitActionTest.php, UndoSubmitActionTest.php, NewEntitySchemaTest.php).
  • AbuseFilter -> (AbuseFilterBlockTest.php).
  • Jade -> (EntityValidatorTest.php).
  • WikibaseLexeme -> (ApiUserBlockedTest.php, SpecialNewLexemeTest.php).
  • EventBus -> (EventFactoryTest.php).
  • Flow -> (RevisionCollectionPermissionsTest.php).
  • Thanks -> (ApiCoreThankUnitTest.php).
  • Wikibase -> (ApiUserBlockedTest.php).
gerritbot added a comment.May 31 2021, 1:43 PM

Change 697421 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/EntitySchema@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697421

gerritbot added a project: Patch-For-Review.May 31 2021, 1:43 PM
gerritbot added a comment.May 31 2021, 2:36 PM

Change 697427 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/AbuseFilter@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697427

gerritbot added a comment.May 31 2021, 2:57 PM

Change 697429 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Jade@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697429

gerritbot added a comment.May 31 2021, 3:34 PM

Change 697434 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/WikibaseLexeme@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697434

gerritbot added a comment.May 31 2021, 3:57 PM

Change 697438 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/EventBus@master] Update DatabaseBlock construct option 'byText' to 'by' use User Identity only

https://gerrit.wikimedia.org/r/697438

gerritbot added a comment.May 31 2021, 4:04 PM

Change 697439 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Flow@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697439

gerritbot added a comment.May 31 2021, 4:28 PM

Change 697441 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Thanks@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697441

gerritbot added a comment.May 31 2021, 4:41 PM

Change 697427 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697427

gerritbot added a comment.May 31 2021, 4:44 PM

Change 697442 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Wikibase@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697442

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).May 31 2021, 5:00 PM
gerritbot added a comment.Jun 1 2021, 3:24 PM

Change 697429 merged by jenkins-bot:

[mediawiki/extensions/Jade@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697429

roman-stolar mentioned this in rEJADfd54da6ea185: Update DatabaseBlock construct option 'by' to use User Identity only.Jun 1 2021, 3:28 PM
gerritbot added a comment.Jun 1 2021, 3:30 PM

Change 697434 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697434

gerritbot added a comment.Jun 1 2021, 3:32 PM

Change 697438 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] Update DatabaseBlock construct option 'byText' to 'by' use User Identity only

https://gerrit.wikimedia.org/r/697438

gerritbot added a comment.Jun 1 2021, 3:32 PM

Change 697441 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697441

gerritbot added a comment.Jun 1 2021, 3:32 PM

Change 697439 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697439

gerritbot added a comment.Jun 1 2021, 3:32 PM

Change 697421 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697421

gerritbot added a comment.Jun 2 2021, 10:33 AM

Change 697727 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Update DatabaseBlock construct option 'by' and 'byText' usage to use User Identity only

https://gerrit.wikimedia.org/r/697727

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jun 2 2021, 12:27 PM
gerritbot added a comment.Jun 2 2021, 1:09 PM

Change 697442 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update DatabaseBlock construct option 'by' to use User Identity only

https://gerrit.wikimedia.org/r/697442

gerritbot added a comment.Jun 2 2021, 5:56 PM

Change 697727 merged by jenkins-bot:

[mediawiki/core@master] Update DatabaseBlock construct option 'by' and 'byText' usage to use User Identity only

https://gerrit.wikimedia.org/r/697727

roman-stolar added a comment.Jun 3 2021, 9:45 AM

@Pchelolo I just double check in code search usage of these options, probably I will just remove them without depreciation.

gerritbot added a comment.Jun 3 2021, 11:01 AM

Change 697936 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Remove DatabaseBlock 'byText' and 'by' with user ID

https://gerrit.wikimedia.org/r/697936

gerritbot added a comment.Jun 4 2021, 9:06 AM

Change 698160 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Hard deprecated DatabaseBlock options 'byText' and 'by' with user ID

https://gerrit.wikimedia.org/r/698160

gerritbot added a comment.Jun 4 2021, 3:18 PM

Change 698160 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecated DatabaseBlock options 'byText' and 'by' with user ID

https://gerrit.wikimedia.org/r/698160

roman-stolar moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.Jun 7 2021, 10:23 AM
• Pchelolo moved this task from On the train to Not deployed extensions on the Platform Team Workboards (MW Expedition) board.Jun 25 2021, 4:58 PM
• Pchelolo moved this task from Not deployed extensions to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
• Pchelolo moved this task from Waiting for Review to Waiting for release on the Platform Team Workboards (MW Expedition) board.Jul 15 2021, 6:09 PM
Zabe subscribed.Sep 27 2021, 9:04 PM
gerritbot added a comment.Sep 29 2021, 3:12 PM

Change 697936 merged by jenkins-bot:

[mediawiki/core@master] Remove DatabaseBlock 'byText' and 'by' with user ID

https://gerrit.wikimedia.org/r/697936

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.3; 2021-10-05).Sep 29 2021, 4:00 PM
• Pchelolo closed this task as Resolved.Oct 19 2021, 3:14 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits