If no user-agent is passed, cuc_agent is 0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Oct 18 2021, 2:54 PM

Description

CheckUser blindly passes result of $wgRequest->getHeader( 'User-Agent' ) to the database.

If no user-agent is passed, $wgRequest->getHeader( 'User-Agent' ) is false. MariaDB stores that boolean as a zero.

We should transform that false to an empty string, which will cause cuc_agent to have more understandable data.

	Subject	Repo	Branch	Lines +/-
	If no user-agent is passed, cuc_agent should be an empty string	mediawiki/extensions/CheckUser	master	+21 -19

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 731766 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CheckUser@master] If no user-agent is passed, cuc_agent should be an empty string

Change 731766 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] If no user-agent is passed, cuc_agent should be an empty string

Calling this fixed :).

	F34700836: image.png
	Oct 20 2021, 8:44 AM