Page MenuHomePhabricator
Create Task
Maniphest T317713

Stop Adyen adapter from sending an additional pending message on success
Closed, ResolvedPublic
Actions

Description

Because we're using PaymentResult::newRedirect rather than newSuccess, the api sends an extra pending message. Use the correct class and add JS code to redirect to the TY page.

See https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/adyen_gateway/adyen_checkout.adapter.php$102

Details

SubjectRepoBranchLines +/-
Stop Adyen adapter from sending an additional pending messagemediawiki/extensions/DonationInterfacemaster+4 -4
Customize query in gerrit

Event Timeline

Ejegg created this task.Sep 13 2022, 10:36 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptSep 13 2022, 10:36 PM
Ejegg moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Sep 14 2022, 1:46 AM
Ejegg added a project: Fundraising Sprint Quarkery.Sep 14 2022, 1:34 PM
jgleeson claimed this task.Sep 14 2022, 2:58 PM
jgleeson moved this task from Backlog to Doing on the Fundraising Sprint Quarkery board.
gerritbot added a comment.Sep 15 2022, 8:37 PM

Change 832568 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[mediawiki/extensions/DonationInterface@master] WIP: Stop Adyen adapter from sending an additional pending message

https://gerrit.wikimedia.org/r/832568

gerritbot added a project: Patch-For-Review.Sep 15 2022, 8:37 PM
jgleeson moved this task from Doing to Review on the Fundraising Sprint Quarkery board.Sep 16 2022, 7:05 PM
gerritbot added a comment.Sep 19 2022, 6:07 PM

Change 832568 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Stop Adyen adapter from sending an additional pending message

https://gerrit.wikimedia.org/r/832568

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2022, 6:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.2; 2022-09-19).Sep 19 2022, 7:00 PM
AnnWF moved this task from Review to Pending Deployment on the Fundraising Sprint Quarkery board.Sep 20 2022, 7:43 PM
XenoRyet added a project: Fundraising Sprint Recursion Excursion.Sep 27 2022, 8:24 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Recursion Excursion board.Sep 28 2022, 12:32 AM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Recursion Excursion board.Oct 4 2022, 7:23 PM
XenoRyet closed this task as Resolved.Oct 11 2022, 7:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits