Page MenuHomePhabricator
Create Task
Maniphest T322292

"Translate this page" button should not appear in ULS for nonexistent pages
Closed, ResolvedPublic
Actions

Description

Currently the "Translate this page" action item is registered inside ULS empty state, even if the page is missing. This is confusing since there is no page to be translated.

Screenshot of this unwanted behaviour:

Screenshot 2022-11-03 at 11.43.12 AM.png (1×2 px, 464 KB)

What should happen instead
The "Translate this page" button should not appear in ULS dropdown for missing pages

Details

SubjectRepoBranchLines +/-
Do not load "Translate page" action button when page doesn't existmediawiki/extensions/ContentTranslationmaster+10 -12
Customize query in gerrit

Event Timeline

ngkountas created this task.Nov 3 2022, 9:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2022, 9:51 AM
ngkountas triaged this task as Medium priority.Nov 3 2022, 9:51 AM
ngkountas added a project: UniversalLanguageSelector.
ngkountas added a project: Desktop Improvements (Vector 2022).
ngkountas edited projects, added ContentTranslation; removed UniversalLanguageSelector.
ngkountas moved this task from Priority: Unified Content & Section Translation to In Review on the Language-Team (Language-2022-October-December) board.
gerritbot added a comment.Nov 3 2022, 9:53 AM

Change 852138 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Do not load "Translate page" action button when page doesn't exist

https://gerrit.wikimedia.org/r/852138

gerritbot added a project: Patch-For-Review.Nov 3 2022, 9:53 AM
Jdlrobson moved this task from Incoming to Work with other teams on the Desktop Improvements (Vector 2022) board.Nov 7 2022, 3:28 PM
gerritbot added a comment.Nov 9 2022, 10:45 AM

Change 852138 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Do not load "Translate page" action button when page doesn't exist

https://gerrit.wikimedia.org/r/852138

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 9 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 9 2022, 11:30 AM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2022-October-December) board.Nov 10 2022, 4:23 PM
Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.Nov 21 2022, 11:40 AM
ngkountas moved this task from Check after deployment to Needs QA on the Language-Team (Language-2022-October-December) board.Nov 29 2022, 11:09 AM
EChukwukere-WMF subscribed.Dec 6 2022, 5:07 AM

Test status : QA PASS

Translate page is not longer shown in ULS in an empty state session

Screen Shot 2022-12-05 at 11.05.05 PM.png (790×1 px, 403 KB)

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-October-December) board.Dec 6 2022, 5:08 AM
Pginer-WMF closed this task as Resolved.Dec 9 2022, 11:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits