Page MenuHomePhabricator

ManageMentors - setting Away status for past dates fails silently without warning
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. As a user with rights to edit Special:ManageMentors, click to edit some mentor's settings.
  2. Click the checkbox Is away? and enter a date that is in the past.

Screen Shot 2023-09-26 at 3.08.47 PM.png (1×1 px, 133 KB)

  1. Click Submit - no warning will be given on incorrectly entered date. The save will silently fail.

Expected behavior

  • a user should be warned the date is incorrect or it should not be possible to select days in the past. The issue is present only on Special:ManageMentors. Mentors while setting their Away status can enter only number of days:

Screen Shot 2023-09-25 at 4.56.45 PM.png (596×1 px, 113 KB)

Note: Since there is no record of changing Away setting in the history on MediaWiki:GrowthMentors.json, it could be confusing for users to figure out what was wrong with saving updated Away status.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 969200 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] ManageMentorsEditForm: Do not allow admins to set mentors as away until past

https://gerrit.wikimedia.org/r/969200

Change 969200 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ManageMentorsEditForm: Do not allow admins to set mentors as away until past

https://gerrit.wikimedia.org/r/969200

Fixed in beta:

  • the selection of past dates is prevented (the calendar doesn't go back past the current calendar display

Screen Shot 2023-11-02 at 11.52.48 AM.png (682×732 px, 68 KB)

  • selection of the current day will display the following warning to users:

Screen Shot 2023-11-02 at 11.51.35 AM.png (1×1 px, 183 KB)