Page MenuHomePhabricator

Don't redact stracktraces containing "eval()'d" in Phatality
Open, Needs TriagePublic

Description

Phatality currently contains a safeguard where any stacktrace containing a ' or " is replaced with (REDACTED), originally introduced as a fix to {T234014}. This errantly catches cases where stacktraces include eval()'d expressions. (See T378531: PHP Notice: Array to string conversion for a recent example.)

Let's adjust the regex to exclude cases where the single quote is immediately preceded with eval().