Make EntityMetaTagsCreatorTestCase's provideTestGetMetaTags dataProvider static
Open, Needs TriagePublic
Actions

Description

EntityMetaTagsCreatorTestCase is an abstract class, which defines an abstract, non-static dataProvider function: provideTestGetMetaTags

The class is extended in these files:

Since this change involves another repo (WikibaseLexeme), it should be done in its own set of commits across Wikibase and WikibaseLexeme

Subject	Repo	Branch	Lines +/-
Re-enable tests, make provideTestGetMetaTags static	mediawiki/extensions/WikibaseLexeme	master	+19 -19
Make dataProviders static in EntityMetaTagsCreatorTestCase	mediawiki/extensions/Wikibase	master	+30 -26
Temporarily skip `LexemeMetaTagsCreatorTest`	mediawiki/extensions/WikibaseLexeme	master	+6 -2

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Open	None	T328919 Upgrade to PHPUnit 10
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T332865 PHPUnit data providers should be simple static functions that return plain data
Open	None	T371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
Open	None	T337154 Make PHPUnit dataProvider static in Wikibase tests
Open	Lucas_Werkmeister_WMDE	T380605 Make EntityMetaTagsCreatorTestCase's provideTestGetMetaTags dataProvider static

Change #1094474 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/WikibaseLexeme@master] Temporarily skip `LexemeMetaTagsCreatorTest`

Change #1094476 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] Make dataProviders static in EntityMetaTagsCreatorTestCase

Change #1094481 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/WikibaseLexeme@master] Re-enable tests, make provideTestGetMetaTags static