File revert counts as 'overwrite', not 'revert'
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Rezonansowy
	Dec 9 2013, 2:38 PM

Description

When someone revert file to older version, in edit history it appears as a new upload, not classic MediaWiki-style file revert.
Example: https://commons.wikimedia.org/w/index.php?title=File:Internet_Explorer_9_icon.svg&action=history

Details

Reference: bz58209

	Subject	Repo	Branch	Lines +/-
	Add separate log action for file reverts	mediawiki/core	master	+26 -8

Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:33 AM

• bzimport added a project: MediaWiki-Page-diffs.

• bzimport set Reference to bz58209.

• bzimport added a subscriber: Unknown Object (MLST).

Rezonansowy created this task.Dec 9 2013, 2:38 PM

See https://commons.wikimedia.org/wiki/Commons:Village_pump#Copyright:_Two_images_from_MS#File upload revert

I guess you want a notification to come up when a file is reverted?

https://www.mediawiki.org/wiki/Help:Notifications

(In reply to comment #2)

I guess you want a notification to come up when a file is reverted?

https://www.mediawiki.org/wiki/Help:Notifications

First of all, but this action just should follow with MediaWiki-revert method:
''Undid revision 123456789 by User (talk)''
not
''User uploaded a new version of File:xxx''

You see, it shouldn't appear as new upload, but a revert.

I guess this bug is even more general? I did a quick test and the 'upload/revert'-actions do not show up (c.f. https://www.mediawiki.org/wiki/API:Logevents)

https://commons.wikimedia.org/w/api.php?action=query&list=logevents&format=json&leprop=title&leaction=upload%2Frevert&leuser=McZusatz&lelimit=10

Bug 30197 has been marked as a duplicate of this bug. ***

Merging comment 1 from bug 30197 (Unused Log upload/revert):
As current type is upload/overwrite used for file reverts. But $wgLogActions
has an entry for that, that should used when reverting a file, that is right.

Ricordisamoa subscribed.Jun 19 2015, 10:13 AM

MGChecker subscribed.Apr 2 2016, 7:22 PM

Restricted Application added subscribers: Luke081515, Aklapper. · View Herald TranscriptApr 2 2016, 7:22 PM

MGChecker awarded a token.Apr 2 2016, 7:22 PM

MGChecker added a project: MediaWiki-Logevents.May 4 2016, 8:02 PM

MGChecker updated the task description. (Show Details)

MGChecker removed a subscriber: • wikibugs-l-list.

MGChecker claimed this task.Oct 1 2018, 4:20 PM

MGChecker added a project: MediaWiki-File-management.

Restricted Application added projects: Commons, Multimedia. · View Herald TranscriptOct 1 2018, 4:20 PM

MGChecker removed a project: MediaWiki-Page-diffs.Oct 1 2018, 6:09 PM

MGChecker moved this task from Incoming to Uploading on the Commons board.