Page MenuHomePhabricator
Create Task
Maniphest T85014

Position event not emitted after slug close
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Click in a slug then onto a focusable node beneath it. The focusable node slides up as the slug closes but the highlight doesn't move because no position event is emitted from the surface observer.

Details

SubjectRepoBranchLines +/-
Simplify slug behaviourVisualEditor/VisualEditormaster+126 -255
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Dec 19 2014, 6:56 PM
Esanders assigned this task to dchan.
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders changed Security from none to None.
Esanders subscribed.
Krenair added a project: VisualEditor.Dec 19 2014, 6:59 PM
Krenair subscribed.

Needs the correct project added

Jdforrester-WMF triaged this task as Medium priority.Dec 19 2014, 7:00 PM
Jdforrester-WMF added a project: VisualEditor-ContentEditable.
Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.Jan 5 2015, 12:14 PM
gerritbot added a project: Patch-For-Review.Feb 12 2015, 3:54 PM
gerritbot subscribed.

Change 190022 had a related patch set uploaded (by Esanders):
Simplify slug behaviour

https://gerrit.wikimedia.org/r/190022

Patch-For-Review

Jdforrester-WMF reassigned this task from dchan to Esanders.Feb 16 2015, 6:50 PM
Jdforrester-WMF moved this task from Planned Maintenance to Blocked on the VisualEditor board.
gerritbot added a comment.Feb 23 2015, 9:00 PM

Change 190022 merged by jenkins-bot:
Simplify slug behaviour

https://gerrit.wikimedia.org/r/190022

Jdforrester-WMF closed this task as Resolved.Feb 24 2015, 1:15 AM
Jdforrester-WMF added a project: WMF-deploy-2015-02-25_(1.25wmf19).
Ryasmeen removed a project: Patch-For-Review.Feb 25 2015, 6:58 AM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Feb 25 2015, 4:28 PM
Jdforrester-WMF mentioned this in rGVED822236c6cad1: Simplify slug behaviour.Mar 3 2015, 7:38 PM
Ryasmeen added a project: Verified-in-Phase0.Mar 16 2015, 7:20 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:27 PM
Jdforrester-WMF edited a custom field.Mar 29 2015, 11:33 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits