In T380537#10346360, @LucasWerkmeister wrote:

• a SECRET_KEY – if it’s anything like Flask / ItsDangerous (and it sounds like it is), this is used to sign the session cookie; probably not much harm in keeping it, but I could also see some value in refreshing it (effectively logging everyone out of the tool, so they can log back in and start with a fresh session)
• the database credentials in replica.my.cnf – the policy asks us to delete these (and I believe there is a process for regenerating them), though it’s not really clear to me what the point is… are we supposed to also clear s54856__bullseyedb in ToolsDB?
• an IPCHECK_KEY – I assume this is used with some external service that I know nothing about
• a SPUR_KEY, as you mentioned – ditto
• a SHODAN_KEY – ditto
• an OAuth client credential pair for the bullseye consumer – as the consumer only has the user identity verification grant, I think we can justify keeping this one, even if the policy doesn’t have an exception for it

Can you shed light on some of these? :)

In T380193#10342014, @RoySmith wrote:

I love Bullseye, but I just don't see the point of continuing to maintain it when there's a WMF-supported service that basically does the same thing. If there's something Bullseye does that IPoid doesn't, then merge it into IPoid.

And certainly, having a single service that's hitting the external Spur API will give us better ability to monitor usage, and provide performance enhancement with a cache.

I noted on that PR:

Thinking out loud, given that iPoid-Service exists, perhaps an API call to that can be used in place of Spur directly?

I've made a backport patch — I'm around to do this today if needed, but given it's a Friday can it wait until Monday?

nb. created a revert (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1091470) and then made a patchdemo using that patch — issue is reproducible on a patchdemo running latest core (e.g. https://167789d4d8.catalyst.wmcloud.org/w/), but not once that change is reverted.

In T379983#10324858, @Jdlrobson wrote:

Yep that matches the errors I'm seeing in logstash. @TheresNoTime are you able to update the description with replication steps? Can you replicate the issue locally (and if so can you fix it by reverting https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1088731 ?)

Maybe related, I've just noticed that I'm getting a load of Uncaught InternalError: too much recursion console errors when searching (Vector 2010) and using arrow keys to navigate the search results is not working as expected:

Acceptance Criteria changed per today's stand-up/planning — this is no longer a cosmetic change and requires functionality:

• Clicking "Edit" should take you to Special:Block/{username}
• Clicking "Remove" should take you to Special:Unblock/{username}

Still can't log in:

Restating my comment on the gerrit changeset, I'd suggest that we revert first and try again after. Is that okay @SD0001?

How does

color: @color-subtle;
font-style: italic;

look?

nb. task T368057: Display infoChip component with total number of past blocks seems to cover this (though fair point on getting the count — perhaps we could pick an arbitrary number (e.g. 30) and instead have the chip show 30+?)

If it helps at all, I can't replicate on Android (2.7.50504-beta-2024-10-01) when viewing the preview:

https://github.com/gopavasanth/ToolWatch/pull/20

(Oh and a side effect of creating the community-tech gerrit group is you can add it as a reviewer to a patch, and it'll add everyone)

How's https://gerrit.wikimedia.org/r/p/wikimedia/+/dashboard/teams:community-tech for an initial idea? Will come back to this in some free time this weekend :-)

lgtm, thank you!

Thanks both, for the comments — admittedly having a center-aligned - does look a little nicer. What do you think?

• Do we want to show an empty cell for block params when the type is 'unblock', or show a message (e.g. below)?
• Is the message "N/A" something which should be a translatable message?
  • (guessing yes, though surprisingly "N/A" is not already a message, so perhaps its bad form..?)
• Is using the message log-action-filter-block-reblock okay for reblocks (i.e. "Block modification")

In T368111#10183394, @JWheeler-WMF wrote:

Updated requirements:

• Remove the "Target" column
• Add a log "Type" with the fields "Blocked" and Unblocked." When row represents "Unblocked," the "Expired" column should show "N/A."

Per the description:

This task is just for including the menu item. No action needs to happen

this change is currently only cosmetic — should this be hidden behind a flag and/or marked to not be merged until follow-up is complete?

PR: Add getPlagiarismRecordsCount function, and show open case count

(rm community tech tag, will pick this up as a volunteer)

Things I've done:

• Ran toolforge envvars create DJANGO_SETTINGS_MODULE "backend.settings"
  • I have no idea why this is needed for this, as you're setting DJANGO_SETTINGS_MODULE, but...
• Changed ~/www/python/src/uwsgi.ini to comment out the line wsgi-file = backend/wsgi.py
  • This may have worked, but using app.py as the docs suggest just seemed simpler and maybe easier to debug!
• Created ~/www/python/src/app.py with the following content:

import os

File:Snorkeling at Lindquist beach - US Virgin Islands March 2021.webm