Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Stabilize WaitForStateChange API #7425

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

aranjans
Copy link
Contributor

@aranjans aranjans commented Jul 18, 2024

fixes #5496.

RELEASE NOTES:

  • grpc.ClientConn: stabilize the WaitForStateChange and GetState methods, which were previously experimental.

@aranjans aranjans added the Type: Feature New features or improvements in behavior label Jul 18, 2024
@aranjans aranjans added this to the 1.66 Release milestone Jul 18, 2024
@aranjans aranjans requested a review from dfawley July 18, 2024 08:15
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (64adc81) to head (395ebf1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7425      +/-   ##
==========================================
- Coverage   81.50%   81.44%   -0.07%     
==========================================
  Files         350      352       +2     
  Lines       26877    26919      +42     
==========================================
+ Hits        21906    21923      +17     
- Misses       3776     3808      +32     
+ Partials     1195     1188       -7     
Files Coverage Δ
clientconn.go 93.09% <ø> (+0.36%) ⬆️

... and 18 files with indirect coverage changes

@aranjans aranjans requested a review from purnesh42H July 23, 2024 07:58
@aranjans aranjans assigned purnesh42H and dfawley and unassigned dfawley Jul 23, 2024
@dfawley dfawley assigned aranjans and unassigned purnesh42H and dfawley Jul 23, 2024
@aranjans aranjans changed the title Stabilize WaitForStateChange API client: Stabilize WaitForStateChange API Jul 24, 2024
@aranjans aranjans assigned dfawley and unassigned aranjans Jul 24, 2024
@dfawley dfawley merged commit 40f3998 into grpc:master Jul 24, 2024
13 checks passed
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize connectivity API methods on ClientConn
3 participants