Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): extend constructor options from gax #676

Merged
merged 1 commit into from
Jan 9, 2020
Merged

fix(types): extend constructor options from gax #676

merged 1 commit into from
Jan 9, 2020

Conversation

stephenplusplus
Copy link
Contributor

This looks more correct to me, but please review!

gax.GoogleAuthOptions is a re-export of require('google-auth-library').GoogleAuthOptions.

gax.GrpcClientOptions extends GoogleAuthOptions with these properties: auth, promise, and grpc.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #676 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
- Coverage   68.25%   68.23%   -0.02%     
==========================================
  Files          36       36              
  Lines       10599    10599              
  Branches      174      174              
==========================================
- Hits         7234     7232       -2     
- Misses       3364     3366       +2     
  Partials        1        1
Impacted Files Coverage Δ
src/index.ts 99.65% <100%> (ø) ⬆️
src/sink.ts 98.3% <0%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091d7dd...08c547f. Read the comment docs.

@bcoe bcoe merged commit 5156538 into master Jan 9, 2020
@bcoe bcoe deleted the spp--658 branch January 9, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants