-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add rudimentary web control panel #183
Conversation
I want it, nice work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
I'm gonna pull this down today and check it out. Thanks Doridian! |
@Doridian it's awesome. I love it. Good for the start of something awesome! Now I think for an initial release of this, we just need a few changes. I would say that changing anything in the web, should overwrite what is in Not as necessary, but could be possible with minimal effort?: I'd also suggest making the list not a multi-selectable list, but rather checkboxes. Perhaps more user friendly. I think this is almost there and this will be an awesome addition. |
I agree that checkboxes are easier to use, actually. Good idea! As for updating the |
Agreed, I think that's plenty for now. Also to clarify (which may not be needed); You may not need to manipulate the Can't wait to see it! Thanks for doing this @Doridian ❤️ |
You ready for me now @Doridian? |
@jef Any time really. Didn't yet find a way I like for it to persist its config, tho. With the |
Okay sounds good. I'll pull it down when I get home from vacation and give it a run. From there, we can get this baby merged in! |
@Doridian I think I'm gonna pull this in today. I'm going to change the base branch to develop and start working on top of it. Probably release as 2.0.0 and will come along with some name changes I have in mind. |
Crap... I really want this in here. I'll pull it down in the near future and get it merged in. This is my top priority. Thank you @Doridian for the patience on this one. |
Okay... Last time, I promise. I won't bring in anything else. Let's resolve these conflicts and iterate on this one. Sorry @Doridian 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going in!!!!
Continued the work started with pull request jef#183
Description
Adds a web panel. Need to set
WEB_PORT
for it to bind. This has no authentication, so don't run this on the public internet without a firewall