Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): add pushbullet, add url with notifications #226

Merged
merged 7 commits into from
Sep 23, 2020

Conversation

fuckingrobot
Copy link
Contributor

Description

  • Adds PushBullet notifications.
  • Sends cart URL when using complex cart actions (Nvidia).
  • Nvidia now respects config when setting up session (will not open browser to log in unless config allows browser open)

.

Testing

Tested with my personal PushBullet account.

@fuckingrobot
Copy link
Contributor Author

fuckingrobot commented Sep 23, 2020

26f9daf#diff-d9d0518f53192ad10be16f2eb45691b5R91-R109

		let givenUrl = link.cartUrl ? link.cartUrl : link.url;

		if (Config.browser.open) {
			if (link.openCartAction === undefined) {
				await open(givenUrl);
			} else {
				givenUrl = await link.openCartAction(browser);
			}
		}

		sendNotification(givenUrl, link);
		return;
	}

	if (await lookupPageHasCaptcha(store, page)) {
		Logger.warn(`✖ [${store.name}] CAPTCHA from: ${graphicsCard}. Waiting for a bit with this store...`);
		await delay(getSleepTime());
		return;
	}

@jef jef changed the title feat(notification): Add PushBullet, send cart URL with notifications feat(notification): add pushbullet, add url with notifications Sep 23, 2020
@jef jef merged commit 74490ea into jef:main Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants