r89523 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r89522
|
r89523
|
r89524
>
Date:
19:22, 5 June 2011
Author:
reedy
Status:
ok (
Comments
)
Tags:
Comment:
* (
bug 28002
) Internal error in ApiFormatRaw::getMimeType
If we just return when no titles, we don't format anything, and everything breaks
Might aswell just unconditionally export, as even with no titles, we still get all the siteinfo and such
Modified paths:
/trunk/phase3/RELEASE-NOTES-1.19
(modified) (
history
)
/trunk/phase3/includes/api/ApiQuery.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/RELEASE-NOTES-1.19
—
—
@@ -98,6 +98,7 @@
99
99
* (bug 29267) always give the servername for meta=siteinfo&siprop=dbrepllag
100
100
* (bug 28897) rvparse doesn’t seem to work with rvsection
101
101
* (bug 25734) API: possible issue with revids validation
102
+* (bug 28002) Internal error in ApiFormatRaw::getMimeType
102
103
103
104
=== Languages updated in 1.19 ===
104
105
Index: trunk/phase3/includes/api/ApiQuery.php
—
—
@@ -484,10 +484,6 @@
485
485
}
486
486
}
487
487
}
488
- // only export when there are titles
489
- if ( !count( $exportTitles ) ) {
490
- return;
491
- }
492
488
493
489
$exporter = new WikiExporter( $this->getDB() );
494
490
// WikiExporter writes to stdout, so catch its
Follow-up revisions
Revision
Commit summary
Author
Date
r91479
Merge
r89523
reedy
19:43, 5 July 2011
r92339
REL1_18 MFT
r89401
,
r89451
,
r89512
,
r89513
,
r89523
,
r89529
,
r89532
,
r89549
,
r...
reedy
23:08, 15 July 2011
Comments
#
Comment by
Reedy
(
talk
|
contribs
)
19:36, 5 July 2011
Tagging for 1.17wmf1 and 1.18
Should be put in 1.17wmf1 to fix the apache logs on the WMF cluster
Status & tagging log
23:08, 15 July 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r89523
[
removed:
1.18]
19:43, 5 July 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r89523
[
removed:
1.17wmf1]
19:36, 5 July 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r89523
[
added:
1.18,1.17wmf1]
21:31, 24 June 2011
Aaron Schulz
(
talk
|
contribs
)
changed the
status
of r89523
[
removed:
new
added:
ok]