Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-6900

Grouping sortWithinGroup should use Sort.RELEVANCE to indicate that, not null

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 5.5
    • modules/grouping
    • None
    • New

    Description

      In AbstractSecondPassGroupingCollector, withinGroupSort uses a value of null to indicate a relevance sort. I think it's nicer to use Sort.RELEVANCE for this – after all it's how the groupSort variable is handled. This choice is also seen in GroupingSearch; likely some other collaborators too.

      martijn.v.groningen is there some wisdom in the current choice that escapes me? If not I'll post a patch.

      Attachments

        1. LUCENE_6900.patch
          33 kB
          David Smiley
        2. LUCENE_6900.patch
          32 kB
          David Smiley

        Issue Links

          breaks

          Bug - A problem which impairs or prevents the functions of the product. SOLR-8940 group.sort broken, can through AIOOBE if clause length differs from sort param, or cast exception if datatypes are incompatible with sort clause types

          • Blocker - Blocks development and/or testing work, production could not run
          • Closed
          relates to

          Task - A task that needs to be done. SOLR-9783 remove no-longer-needed sortWithinGroup null checks in (Search|Top)Group[s]ShardResponseProcessor

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              dsmiley David Smiley
              dsmiley David Smiley
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: