Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-7788

fail precommit on unparameterised log messages and examine for wasted work/objects

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 8.6
    • None
    • None
    • New

    Description

      SOLR-10415 would be removing existing unparameterised log.trace messages use and once that is in place then this ticket's one-line change would be for 'ant precommit' to reject any future unparameterised log.trace message use.

      Attachments

        1. gradle_only.patch
          12 kB
          Erick Erickson
        2. gradle_only.patch
          12 kB
          Erick Erickson
        3. LUCENE-7788.patch
          2 kB
          Christine Poerschke
        4. LUCENE-7788.patch
          1 kB
          Christine Poerschke

        Issue Links

          fixes

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-12301 Umbrella issue: paramaterize logging calls in Solr, use consistent naming conventions for the logger

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-10415 Within solr-core, debug/trace level logging should use parameterized log messages

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed
          is related to

          Wish - General wishlist item. SOLR-12419 standardise solr/contrib (private) logger names

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. SOLR-12557 standardise solr/core (private) logger names

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-11884 find/fix inefficiencies in our use of logging

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-12286 Wrap log instances in "if (LOG.isLevelEnabled) { log... }

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. SOLR-10415 Within solr-core, debug/trace level logging should use parameterized log messages

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed
          links to

          Web Link GitHub Pull Request #1428

          Activity

            People

              erickerickson Erick Erickson
              cpoerschke Christine Poerschke
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m