Why is my input always high

tina220800 · March 12, 2020, 9:47am

I have a temperature control project in which I have a fan that is automatically turned on or off depending on the reading given from a sensor. And that part works fine but now I need a manual override toggle switch which when it is closed/on it will turn the fan on until manually switched off. at which point it will resume the normal program. However the switch is constantly reading as high and therefore stopping the rest of the function regardless of the switches position. aside from this, will the code work as intended once this issue is fixed or am I missing something?

edit: my switch pin is connected 1 to pin 7 and 3 to 5V.

  lcd.begin(16, 2);
  Serial.begin(9600); 
  
  pinMode(fan,OUTPUT);
  pinMode(switch_pin, INPUT);
  
  delay(500);
 }//Delay to let system boot


void loop() {
  
if
  (digitalRead(switch_pin) == HIGH)
  {digitalWrite(fan,LOW);
  lcd.setCursor(0,1);
  lcd.print("Manual Stop");
  Serial.print("Manual Stop");}

if
  (digitalRead(switch_pin) == LOW){
  DHT.read11(dht_apin);
  Serial.print(" Temperature = ");
  Serial.print(DHT.temperature); 
  Serial.println("C  ");    
  delay(1500);//Wait 1.5 seconds before accessing sensor again.
   
  lcd.setCursor(0,0);
  lcd.print(DHT.temperature);
  lcd.println(" *C");
  
  if
    (isnan(DHT.temperature)) {
    Serial.println(" Failed to read transformer temperature");
    lcd.print("Failed reading");}

  if
    (DHT.temperature>=40) 
    {digitalWrite(fan,HIGH);
    lcd.setCursor(0,1);
    lcd.print("Fan = ON");
    Serial.print("Fan = ON");}

  else
    {digitalWrite(fan,LOW);
    lcd.setCursor(0,1);
    lcd.print("Auto Fan = OFF");
    Serial.print("Auto Fan = OFF");}
    }

 }

TEMP_SENSOR_PROJECT.ino (1.31 KB)

LarryD · March 12, 2020, 9:56am

Change:
pinMode(switch_pin, INPUT);
To:
pinMode(switch_pin, INPUT_PULLUP);

Show us a good schematic of your circuit.
Show us a good image of your wiring.
Give links to components.
Posting images:
https://forum.arduino.cc/index.php?topic=519037.0

Use CTRL T to format your code.
Attach your ‘complete’ sketch between code tags, use the </> icon in the posting menu. [code]Paste your sketch here[/code]

FYI

TomGeorge · March 12, 2020, 9:57am

Hi,

Can you please post a copy of your circuit, in CAD or a picture of a hand drawn circuit in jpg, png?

How have you got your switch wired?
Do you have a pull up or pull down resistor on the digital input that your switch is connected?
Do you have a DMM?

Thanks.. Tom..

anon73444976 · March 12, 2020, 9:59am

Consistent positioning of { and } would be helpful.
You only read temperature conditionally, but test temperature anyway - is that intentional?

tina220800 · March 12, 2020, 12:19pm

This is the simplest way for me personally. Apologies if this is difficult to understand. this is how everything is connected excluding earths.
And as for the wiring most of it isn't visible so the schematic is the best thing to follow.

anon57585045 · March 12, 2020, 12:25pm

Configure the input with INPUT_PULLUP as suggested in reply #1, and then run pin 3 of the toggle switch to ground instead of +5V. The polarity of the switch will now be opposite, it will be LOW when pressed. But that can always be accommodated in the program logic.

GolamMostafa · March 12, 2020, 1:22pm

TheMemberFormerlyKnownAsAWOL:
Consistent positioning of { and } would be helpful.

void setup()
{
  lcd.begin(16, 2);
  Serial.begin(9600);

  pinMode(fan, OUTPUT);
  pinMode(switch_pin, INPUT);

  delay(500);
}//Delay to let system boot


void loop()
{
  if (digitalRead(switch_pin) == HIGH)
  {
    digitalWrite(fan, LOW);
    lcd.setCursor(0, 1);
    lcd.print("Manual Stop");
    Serial.print("Manual Stop");
  }

  if (digitalRead(switch_pin) == LOW)
  {
    DHT.read11(dht_apin);
    Serial.print(" Temperature = ");
    Serial.print(DHT.temperature);
    Serial.println("C  ");
    delay(1500);//Wait 1.5 seconds before accessing sensor again.

    lcd.setCursor(0, 0);
    lcd.print(DHT.temperature);
    lcd.println(" *C");
   }

    if (isnan(DHT.temperature))
    {
      Serial.println(" Failed to read transformer temperature");
      lcd.print("Failed reading");
    }

    if (DHT.temperature >= 40)
    { 
      digitalWrite(fan, HIGH);
      lcd.setCursor(0, 1);
      lcd.print("Fan = ON");
      Serial.print("Fan = ON");
    }

    else
    { 
      digitalWrite(fan, LOW);
      lcd.setCursor(0, 1);
      lcd.print("Auto Fan = OFF");
      Serial.print("Auto Fan = OFF");
    }
}

tina220800 · March 16, 2020, 8:16am

So, I've changed my code to INPUT_PULLUP as well as swapped pin 3 to GND instead of 5V. none of which has made a difference. And yes, the temperature needs to be read consistently.

UKHeliBob · March 16, 2020, 8:18am

Please post your code as it is now

tina220800 · March 16, 2020, 9:00am

TomGeorge:
Hi,

Can you please post a copy of your circuit, in CAD or a picture of a hand drawn circuit in jpg, png?

How have you got your switch wired?
Do you have a pull up or pull down resistor on the digital input that your switch is connected?
Do you have a DMM?

Thanks.. Tom..

I was told on a separate forum not to use a resistor and I don't know what a DMM is?

UKHeliBob:
Please post your code as it is now

here is my code now.

#include <LiquidCrystal.h>
#include <dht.h>

#define dht_apin A0
dht DHT;

const int rs = 12, en = 11, d4 = 5, d5 = 4, d6 = 3, d7 = 2;
int fan = 6;
int switch_pin = 7;

LiquidCrystal lcd(rs, en, d4, d5, d6, d7);

void setup() {

lcd.begin(16, 2);
Serial.begin(9600);

pinMode(fan,OUTPUT);
pinMode(switch_pin,INPUT_PULLUP);

delay(500);
}//Delay to let system boot

void loop() {

if
(digitalRead(switch_pin) == HIGH)
{digitalWrite(fan,LOW);
lcd.setCursor(0,1);
lcd.print("Manual Stop");
Serial.print("Manual Stop");}

if
(digitalRead(switch_pin) == LOW){
DHT.read11(dht_apin);
Serial.print(" Temperature = ");
Serial.print(DHT.temperature);
Serial.println("C ");
delay(1500);//Wait 1.5 seconds before accessing sensor again.

lcd.setCursor(0,0);
lcd.print(DHT.temperature);
lcd.println(" *C");

if
(isnan(DHT.temperature)) {
Serial.println(" Failed to read transformer temperature");
lcd.print("Failed reading");}

if
(DHT.temperature>=40)
{digitalWrite(fan,HIGH);
lcd.setCursor(0,1);
lcd.print("Fan = ON");
Serial.print("Fan = ON");}

else
{digitalWrite(fan,LOW);
lcd.setCursor(0,1);
lcd.print("Auto Fan = OFF");
Serial.print("Auto Fan = OFF");}
}

}

UKHeliBob · March 16, 2020, 9:03am

You need a pullup or pulldown resistor on the switch if you don't use a pinMode() of INPUT_PULLUP to activate the built in resistor

DMM - Digital MultiMeter

tina220800 · March 16, 2020, 9:06am

Ah yes I have a DMM and my program is now using the pullup but I'm still not getting anywhere with it.

anon73444976 · March 16, 2020, 9:10am

but I'm still not getting anywhere with it.

What a waste of words.

Tell us what the code IS doing

system · March 16, 2020, 9:21am

When you changed to input pullup did you:

wire the switch from the pin to ground, and
change the code logic so that switch open is high, closed is low?

UKHeliBob · March 16, 2020, 10:34am

tina220800:
Ah yes I have a DMM and my program is now using the pullup but I'm still not getting anywhere with it.

Post your code

TomGeorge · March 16, 2020, 10:40am

Hi,
I think you have a problem here, is it a drawing error or do you have the fan ON continuously?

In fact check your fan wiring as you have it connected to live and the UNO gnd!!!!!! not the mains Neutral.

Tom....

TomGeorge · March 16, 2020, 10:47am

Hi,
Can I suggest you get a pencil and paper out and hand draw your circuit.
Reverse engineer your project so you will be drawing EXACTLY what you have.

Thanks.. Tom..

tina220800 · March 16, 2020, 1:34pm

UKHeliBob:
Post your code

I already posted my code in reply to your other comment. but here it is again.

#include <LiquidCrystal.h>
#include <dht.h>

#define dht_apin A0
dht DHT;

const int rs = 12, en = 11, d4 = 5, d5 = 4, d6 = 3, d7 = 2;
int fan = 6;
int switch_pin = 7;

LiquidCrystal lcd(rs, en, d4, d5, d6, d7);

void setup() {

lcd.begin(16, 2);
Serial.begin(9600);

pinMode(fan,OUTPUT);
pinMode(switch_pin,INPUT_PULLUP);

delay(500);
}//Delay to let system boot

void loop() {

if
(digitalRead(switch_pin) == HIGH)
{digitalWrite(fan,LOW);
lcd.setCursor(0,1);
lcd.print("Manual Stop");
Serial.print("Manual Stop");}

if
(digitalRead(switch_pin) == LOW){
DHT.read11(dht_apin);
Serial.print(" Temperature = ");
Serial.print(DHT.temperature);
Serial.println("C ");
delay(1500);//Wait 1.5 seconds before accessing sensor again.

lcd.setCursor(0,0);
lcd.print(DHT.temperature);
lcd.println(" *C");

if
(isnan(DHT.temperature)) {
Serial.println(" Failed to read transformer temperature");
lcd.print("Failed reading");}

if
(DHT.temperature>=40)
{digitalWrite(fan,HIGH);
lcd.setCursor(0,1);
lcd.print("Fan = ON");
Serial.print("Fan = ON");}

else
{digitalWrite(fan,LOW);
lcd.setCursor(0,1);
lcd.print("Auto Fan = OFF");
Serial.print("Auto Fan = OFF");}
}

}

blomcrestlight:
When you changed to input pullup did you:

wire the switch from the pin to ground, and

change the code logic so that switch open is high, closed is low?

yes my pin is now to ground. And I have done it both ways with no difference, it still reads "manual stop".

TheMemberFormerlyKnownAsAWOL:
What a waste of words.

Tell us what the code IS doing

My code is still doing exactly what i said in my first message. The switch is only reading high and therefore the LCD is only "manual stop". Whether i flick the switch up or down it's only reading one way and seems it is stopping the rest of my program from running.

TomGeorge · March 16, 2020, 1:38pm

Hi,

Please read the post at the start of any forum , entitled "How to use this Forum".
OR
**http://forum.arduino.cc/index.php/topic,148850.0.html. **
Then look down to item #7 about how to post your code.
It will be formatted in a scrolling window that makes it easier to read.

Tom...

UKHeliBob · March 16, 2020, 1:48pm

I already posted my code in reply to your other comment

But you have changed it since then

  if (digitalRead(switch_pin) == HIGH)
  {
    digitalWrite(fan, LOW);
    lcd.setCursor(0, 1);
    lcd.print("Manual Stop");
    Serial.print("Manual Stop");
  }

As you are now using INPUT_PULLUP the state of the pin will be HIGH when the switch is not closed. Have you now got the switch wired to take the pin LOW when the switch is closed ?

Topic		Replies	Views
Fan reading on and off at the same time. Programming	4	368	May 6, 2021
How to program pin high until ?? Programming	14	6417	May 5, 2021
digitalRead wont respond when PIN is high Programming	4	1524	May 5, 2021
Make manual start/stopp button override sensorreadings/function Programming	17	2158	May 5, 2021
enquiry on fan control with temperature sensor DHT 11 Programming	13	4589	May 5, 2021

Why is my input always high

Related topics