Take automatic game screenshots in Quick Customization #7116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementPasteau
commented
Oct 29, 2024
newIDE/app/src/ExportAndShare/BrowserExporters/BrowserS3PreviewLauncher/index.js
Show resolved
Hide resolved
4ian
reviewed
Oct 30, 2024
| captureOptions, | ||
| }); | ||
|
|
||
| ipcRenderer.removeAllListeners('preview-window-closed'); |
There was a problem hiding this comment.
What if I launch two or 3 or more previews?
There was a problem hiding this comment.
This only works for the final preview launched indeed, I think that's fine?
newIDE/app/src/MainFrame/EditorContainers/HomePage/LearnSection/TutorialsCategoryPage.js
Show resolved
Hide resolved
AlexandreSi
reviewed
Oct 30, 2024
| @@ -0,0 +1,18 @@ | |||
| /* | |||
| * GDevelop Core | |||
| * Copyright 2008-2016 Florian Rival ([email protected]). All rights | |||
There was a problem hiding this comment.
Suggested change
| * Copyright 2008-2016 Florian Rival ([email protected]). All rights | |
| * Copyright 2008-2024 Florian Rival ([email protected]). All rights | |
AlexandreSi
reviewed
Oct 30, 2024
newIDE/app/src/ExportAndShare/BrowserExporters/BrowserS3PreviewLauncher/index.js
Outdated
Show resolved
Hide resolved
ClementPasteau
force-pushed
the
preview-screenshot
branch
from
af09de4
to
94ada62
Compare
4ian
reviewed
Oct 31, 2024
4ian
reviewed
Oct 31, 2024
4ian
reviewed
Oct 31, 2024
4ian
reviewed
Oct 31, 2024
4ian
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: