Move bswap to builtins. Remove bswap16 #2417
Merged
+1,538
−1,822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might even be worth transferring this to builtins.ts and generating it immediately to binaryen IR. |
MaxGraey
changed the title
dcodeIO
reviewed
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bswapfrompolyfills.tsand expose it as compiler's builtin.bswap16. We didn't use it and I can't imagine where it would be needed. So removing it and don't mark this PR as breaking changed due to its mostly internal change.Type#toUnsignedhelper which try to force type to unsigned. Useful for sign agnostic operations, especially generic types, due to reduce polymorphic noise.polyfills.tsand according tests. Movebswaptests totests/builtins