Skip to content

Refactor branch / select sign checks from rshift to cmp with zero #2426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2022

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Aug 9, 2022

Motivation:

Right shifts makes sense mostly for single expressions or complex conditions. While single if (x < 0) or select(..., x < 0) usually fused to single instruction js / jns / cmovs / cmovns on wasm engines

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO August 9, 2022 13:33
@MaxGraey MaxGraey merged commit e612355 into AssemblyScript:main Aug 15, 2022
@MaxGraey MaxGraey deleted the revert-shr-in-branches branch August 15, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant