-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code coverage & update action versions #1954
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
==========================================
+ Coverage 71.44% 71.56% +0.11%
==========================================
Files 32 32
Lines 13849 13849
==========================================
+ Hits 9895 9911 +16
+ Misses 3954 3938 -16 ☔ View full report in Codecov by Sentry. |
@gdalle if I gave you relevant repo/org permissions (and let me know which ones) would you be able to setup the key? |
Sure but it's literally a 15 second procedure and I explain it in great detail on the discourse post, so don't feel compelled to bring me along. I'd be honored though |
The right way is to add an organization wide secret |
And actually since we've seen a codecov report in the present PR, it looks like the setup already works? |
Cool, okay will merge |
Hi Billy! It seems like this is good to go? |
@gdalle this is breaking CI with say "Error: Unable to resolve action I'm going to revert and let you reopen with a fix. |
…1954)" (EnzymeAD#1974)" This reverts commit e2b0e41.
done in #1977, sorry for the typo, it was v2 and not v4 |
Hi there!
I looked into the lack of code coverage (e.g. in this CI log), and it turns out you're using a very outdated version of the Codecov action, which severely limits your uploads.
The solution is to update the action and add a secret
CODECOV_TOKEN
to the repo, following the procedure I described here: https://discourse.julialang.org/t/psa-new-version-of-codecov-action-requires-additional-setup/109857.I used the opportunity to update other action versions.