Add header files to ClangEnzyme target #2062
Conversation
enzyme/Enzyme/CMakeLists.txt
Outdated
| @@ -208,6 +208,13 @@ target_compile_options(ClangEnzymeFlags INTERFACE "-fplugin=$<TARGET_FILE:ClangE | |||
| add_custom_target(ClangEnzymeDummy "" DEPENDS ClangEnzyme-${LLVM_VERSION_MAJOR}) | |||
| add_dependencies(ClangEnzymeFlags ClangEnzymeDummy) | |||
|
|
|||
| set_property(TARGET ClangEnzyme-${LLVM_VERSION_MAJOR} | |||
| PROPERTY PUBLIC_HEADER | |||
| ${PROJECT_SOURCE_DIR}/include/enzyme/enzyme | |||
There was a problem hiding this comment.
also can we add a warning to the top of the file:
// These files are auto-generated and should not be generated. They are installed by Enzyme to represent the internal behavior of the compiler which are not impacted by a source modification.
There was a problem hiding this comment.
to the top of the file
you mean the top of the line or the top of the include files?
There was a problem hiding this comment.
to the top of the include files
|
We probably also need to change the capitalization to be consistent with the files. There's a clash between |
I don't quite follow here, the installed file should be in some /include dir no? |
Yes they are in |
|
Oh I see what you mean. Maybe we can move these files to
include/runtime/enzyme.
It doesn’t need to be on a valid include path anyways since clang auto
includes it.
So the question is just making sure the tools are happy.
If that doesn’t work, then yeah let’s find a good way to fix this properly
…On Sat, Aug 31, 2024 at 10:46 AM Julian Andrej ***@***.***> wrote:
We probably also need to change the capitalization to be consistent with
the files. There's a clash between enzyme and Enzyme as the top directory
at the moment.
I don't quite follow here, the installed file should be in some /include
dir no?
Yes they are in include/Enzyme/$HEADER while the internal files include
from include/enzyme/$HEADER.
—
Reply to this email directly, view it on GitHub
<#2062 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXDFWVUZWJVV7S6HEV3ZUHQL5AVCNFSM6AAAAABNNELF5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSHEZTSOBSGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
It depends on what you want it to look like from the source level where the files are included. Doing seems like a clean solution to me (which would require only renaming the install directory) |
|
Isn’t that what the user presently needs to do, or am I
misremembering/misunderstanding?
…On Sat, Aug 31, 2024 at 11:09 AM Julian Andrej ***@***.***> wrote:
It depends on what you want it to look like from the source level where
the files are included. Doing
#include <enzyme/enzyme>
seems like a clean solution to me (which would require only renaming the
install directory)
—
Reply to this email directly, view it on GitHub
<#2062 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJTUXD7ETR2RXMAYWO5KBLZUHTDJAVCNFSM6AAAAABNNELF5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRSHE2DOOJWGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
They should, but no headers were installed previously. Also if they are installed they're in |
|
we don't presently install any "Enzyme" (the library) headers, iirc -- so can we not have that directory, and only the runtime one? |
|
To clarify, current main branch has this Enzyme/enzyme/Enzyme/CMakeLists.txt Lines 214 to 218 in b006eb2 PUBLIC_HEADER DESTINATION is wrong. The changes in this PR don't address this yet.
|
|
ping @wsmoses |
|
oh didn't realize you don't have merge rights. Set it to automerge. |
|
@wsmoses that won't work, since there are outdated required checks that won't run. You'll need to merge manually. |
|
ping @wsmoses |
* main: (49 commits) Fix iv of constant (#2141) Update benchmarks (#2035) Implement tgamma derivative (#2140) tgamma error improvement (#2139) Improve cache index error message (#2138) Fixes warnings and adds missing header guards (#2124) mlir: cache and reuse reverse funcs (#2133) mlir: implement forward mode for func.call (#2134) mlir: Func call reverse diff (#2127) Update build_tarballs.jl Fix combined temp cache for reverse (#2131) Improve runtime activity err message (#2132) Fix undef value storage (#2129) Adapt to const tblgen (#2128) Add gcloaded TT (#2125) Fix blas decl updater indexing (#2123) Add header files to ClangEnzyme target (#2062) Improve unknown function error messages (#2120) Fix handle sync (#2122) Support more Julia 1.11 functions (#2121) ...
* main: (49 commits) Fix iv of constant (#2141) Update benchmarks (#2035) Implement tgamma derivative (#2140) tgamma error improvement (#2139) Improve cache index error message (#2138) Fixes warnings and adds missing header guards (#2124) mlir: cache and reuse reverse funcs (#2133) mlir: implement forward mode for func.call (#2134) mlir: Func call reverse diff (#2127) Update build_tarballs.jl Fix combined temp cache for reverse (#2131) Improve runtime activity err message (#2132) Fix undef value storage (#2129) Adapt to const tblgen (#2128) Add gcloaded TT (#2125) Fix blas decl updater indexing (#2123) Add header files to ClangEnzyme target (#2062) Improve unknown function error messages (#2120) Fix handle sync (#2122) Support more Julia 1.11 functions (#2121) ...
No description provided.