original port should not be ignored (fusionauth-issues/issues/2250)

[MarekUniq]

Summary

original port should not be ignored (FusionAuth/fusionauth-issues#2250)

Steps to reproduce

Start docker image with port mapping 2222:9011

--- docker-compose.yml ---
services:
fusionauth:
image: fusionauth/fusionauth-app:1.45.2
ports:
- 2222:9011
--- docker-compose.yml ---

Configure "Google Identity Provider" (possibly any other provider)

Goto URL http://loalhost:2222/admin

Click on "Google Identity Provider" button to log in

Login fails because of wrong redirect_uri:
redirect_uri=http://localhost:9011/oauth2/callback

Expected redirect_uri:

redirect_uri=http://localhost:2222/oauth2/callback

Change in PR

Change is tested with version 1.45.2 by replacing just one java class (HTTPRequest) in docker image using the following technique:

Dockerfile

FROM fusionauth/fusionauth-app:1.45.2
USER root
RUN apt update && apt install unzip zip
USER fusionauth
WORKDIR /usr/local/fusionauth/fusionauth-app/lib
COPY --chown=fusionauth ./build/ ./build/
RUN unzip ./java-http-0.1.13.jar -d unzipped
RUN cp ./build/classes/io/fusionauth/http/server/HTTPRequest.class ./unzipped/io/fusionauth/http/server/HTTPRequest.class
RUN (cd ./unzipped ; zip -u ../java-http-0.1.13.jar)
RUN rm -rf ./build ./unzipped

[robotdan]

@voidmain thoughts on this one?

[voidmain]

Is this necessary? I don't think you can have spaces around port numbers per spec.

Also, we use the java coding standards so this needs curly braces for the if-statement.

Finally, this could fail really hard if the parseInt fails. This should protect against bad values and fall back to the server port.

[MarekUniq]

• trim() removed
• curly braces for the if-statement added
• NumberFormatException handling added to parseInt
  • negative test cases added to test NumberFormatException handling

[voidmain]

Left some comments. This looks good in principle. It just needs some cleanup and some defensive coding.

[voidmain]

LGTM