Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This grid-def file is used in GSI #3120

Merged
merged 3 commits into from
Oct 24, 2024
Merged

This grid-def file is used in GSI #3120

merged 3 commits into from
Oct 24, 2024

Conversation

rtodling
Copy link

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Revision of code to something more general and better looking. Only relevant for GSI and corresponding codes.

Related Issue

@rtodling rtodling requested a review from a team as a code owner October 24, 2024 16:26
@rtodling
Copy link
Author

Wow ... I only changed one file and got all these sorts of other changes in my PR! Not sure what's going on here.

@rtodling rtodling changed the base branch from main to develop October 24, 2024 16:34
@rtodling rtodling added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Oct 24, 2024
@tclune
Copy link
Collaborator

tclune commented Oct 24, 2024

Wow ... I only changed one file and got all these sorts of other changes in my PR! Not sure what's going on here.

Glad you found it.

tclune
tclune reviewed Oct 24, 2024
View reviewed changes
base/MAPL_DefGridName.F90 Outdated Show resolved Hide resolved
@tclune tclune merged commit fd4b1b4 into develop Oct 24, 2024
36 checks passed
@tclune tclune deleted the feature/rtodling/used_in_gsi branch October 24, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtodling @tclune