Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tclune/#3140 create field factory #3143

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Feature/tclune/#3140 create field factory #3143

merged 1 commit into from
Nov 3, 2024

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Nov 1, 2024

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

See commit message

Related Issue

@tclune
Fixes #3140 - create field factory
ac1efc5 
This PR is the first of what will be a sequence of changes to wrap
ESMF_Field functionality.  The change introduces a new subdirectory
`field` and the following extensions:

- MAPL_FieldCreate
- MAPL_FieldReset
- MAPL_FieldInfo  (only internal info items for now)

The code compiles and passes rudimentary unit tests, but is not used
elsewher in MAPL.

Subsequent PRs will refactor other layers to use this as well as
relocate some all-but-redundant bits.
@tclune tclune added 🎁 New Feature This is a new feature 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Nov 1, 2024
@tclune tclune requested a review from a team as a code owner November 1, 2024 18:40
@tclune tclune changed the base branch from main to release/MAPL-v3 November 1, 2024 18:40
@tclune tclune added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label Nov 1, 2024
darianboggs
darianboggs approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@darianboggs darianboggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All suggestions are optional.

@tclune
Copy link
Collaborator Author

tclune commented Nov 3, 2024

All suggestions are optional.

It was a good suggestion - other than that it does not work.

I should add that non-allocatable strings would work, but then we have to pad them and use trim and all that. I may look at that for the next revision.

@tclune tclune merged commit 1373a4d into release/MAPL-v3 Nov 3, 2024
49 of 54 checks passed
@tclune tclune deleted the feature/tclune/#3140-create-field-factory branch November 3, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darianboggs darianboggs darianboggs approved these changes

Assignees

@darianboggs darianboggs

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @darianboggs