review dev-onboarding-quick-setup.md #5868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes based on first run through
|
@zliu41 I think we should reassign this pull request, if we still care about it? |
|
This PR was never meant to be merged, just used for feedback submission. The content is likely outdated and this branch should likely just be closed. |
|
Thank you @nstanford5! @zliu41 could you please still take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall it looks great -- though I still have some questions..
Where is the Plutus compiler? I don't see instructions on installing it -- am I supposed to clone the Plutus repo and build something? Is it in Nix?
What if I'm not using Nix? It says you need 'libsodium' 'blst' and 'secp256k1' -- but how? Can they be installed at the command line? Do they need to be built from source?
Plutus formatting. This may be the standard -- but it made coding along with the demo extremely tedious in regards to whitespace characters. It seems like the formatting is to make things line up well, but actually spacing these out is a nightmare. Plus, the "Data.Time" program will yell at you for using tabs instead of spaces. I assumed this meant I needed to be diligent about my formatting only to come upon the Plutus code and be thrown for a loop. I stopped coding along and started copy/pasting, which I try to avoid in this demos so that I can better grasp what is happening in the code.
The VestingContract example is great for an intro -- useful, but simple. I also really like the conclusion that details: What are the steps to using this in the real world? I think it is one of the most common questions after an example like this.
This demo could benefit from an accompanying video -- most of the public videos related to "Intro to Plutus" still use the Plutus Playground, I couldn't find any that were relevant to getting started as reflected in this doc.
You may consider this two separate documents...
Overall this is greatly improved!