Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Add option to disable BF16 support #480

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Add option to disable BF16 support #480

merged 1 commit into from
Jun 4, 2022

Conversation

gevtushenko
Copy link
Collaborator

This PR addresses the following issue. I considered eliminating of cuda_bf16.h header inclusion, but it might lead to issues when algorithm header relies on some different header:

#include <cub/util_type.cuh> // omitted bf16 specializations based on `__CUDA_BF16_TYPES_EXIST__`
#include <cuda_bf16.h> // defined `__CUDA_BF16_TYPES_EXIST__`
#include <cub/device/device_radix_sort.cuh> // expects bf16 specializations in `util_type.h`

It seems to be safer to provide the disable macro that @leofang's suggested.

@gevtushenko gevtushenko mentioned this pull request May 11, 2022
Closed
@alliepiper alliepiper linked an issue May 11, 2022 that may be closed by this pull request
Need a macro to disable bf16 support? #478
Closed
@alliepiper alliepiper added this to the 2.0.0 milestone May 11, 2022
@alliepiper alliepiper added type: enhancement New feature or request. P1: should have Necessary, but not critical. labels May 11, 2022
leofang
leofang approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @senior-zero!

@leofang
Copy link
Member

leofang commented May 11, 2022

Would this be included in a 1.x patch release, or it's 2.0 only?

@alliepiper
Copy link
Collaborator

Would this be included in a 1.x patch release, or it's 2.0 only?

It'll be in 2.0.

gevtushenko added a commit to gevtushenko/thrust that referenced this pull request Jun 4, 2022
@gevtushenko
Testing NVIDIA/cub#480
05a1a6c
@gevtushenko gevtushenko added testing: gpuCI in progress Started gpuCI testing. testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Jun 4, 2022
@gevtushenko gevtushenko merged commit 1b61fc9 into NVIDIA:main Jun 4, 2022
@leofang leofang mentioned this pull request Sep 10, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leofang leofang leofang approved these changes

@alliepiper alliepiper alliepiper approved these changes

Assignees
No one assigned
Labels
P1: should have Necessary, but not critical. testing: gpuCI passed Passed gpuCI testing. type: enhancement New feature or request.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Need a macro to disable bf16 support?
3 participants
@gevtushenko @leofang @alliepiper