Bump Gradle and Nebula versions to latest #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carl-mastrangelo you probably want to do another push on this PR too to fix the oracle -> open JDK issues. |
carl-mastrangelo
force-pushed
the
gradlebump
branch
from
f960678
to
8ef7b7d
Compare
|
@qiangdavidliu Done! BTW, You should probably test with multiple JDKs, which this change should allow us to do. |
|
cc: @artgon |
|
@carl-mastrangelo looks like the build is still failing even with OpenJDK |
|
Gradle 5 separates the compile and runtime scope of modules: https://docs.gradle.org/5.0/userguide/java_library_plugin.html#sec:java_library_separation You'll need to add a few direct dependencies to |
|
@brharrington @qiangdavidliu Done, PTAL |
qiangdavidliu
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to show the necessity of #397 , I tried building governator with Java11. I was unable to do so because the version string parser couldn't parse JDK11 version: