Breadcrumbs and translations #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Quetzacoalt91
commented
Oct 14, 2020
•
Quetzacoalt91
commented
| Questions | Answers |
|---|---|
| Description? | Fixes @sarahdib feedback about missing breadcrumbs and translations in #77 |
| Type? | bug fix |
| BC breaks? | Nope |
| Deprecations? | Nope |
| Fixed ticket? | / |
| How to test? | Breadcrumbs are now displayed and some of the strings now use the core translations. |
Quetzacoalt91
force-pushed
the
breadcrumbs-and-translations
branch
from
dfedb90
to
2f2f62b
Compare
kpodemski
approved these changes
Oct 14, 2020
atomiix
reviewed
Oct 15, 2020
Co-authored-by: atomiix <[email protected]>
atomiix
approved these changes
Oct 16, 2020
Progi1984
approved these changes
Oct 19, 2020
PierreRambaud
approved these changes
Oct 21, 2020
|
QA will be done on new-module |
|
Any one please help me, I don't know how github works, but for the block module wishlist, I can not find translation, for eg it is write "You need to be logged in to save products in your wishlist." where can I translate this part for front end??! |
|
Hi @liviu-v If we use GitHub issues only to discuss about bugs and new features for the PrestaShop project. We do not provide help on GitHub. I would suggest looking for help on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.