Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roaring64_bitmap_move_from_roaring32 function #649

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

Dr-Emann
Copy link
Member

@Dr-Emann Dr-Emann commented Aug 4, 2024

This allows creating a 64 bitmap cheaply from a roaring_bitmap_t. Ideally, we should add a roaring64_bitmap_add_offset too.

Related to #549

Open to naming suggestions

This allows creating a 64 bitmap cheaply from a roaring_bitmap_t. Ideally, we
should add a `roaring64_bitmap_add_offset` too.
@Dr-Emann Dr-Emann requested a review from SLieve August 4, 2024 19:01
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful code.

include/roaring/roaring64.h Outdated Show resolved Hide resolved
@Dr-Emann Dr-Emann changed the title Add roaring64_bitmap_steal_roaring32 function Add roaring64_bitmap_move_from_roaring32 function Aug 5, 2024
@lemire
Copy link
Member

lemire commented Aug 7, 2024

Merging. Will be part of the next release.

@lemire lemire merged commit 99ef8b2 into master Aug 7, 2024
38 checks passed
@Dr-Emann Dr-Emann deleted the push-svouztsxsoml branch August 7, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants